Expose last share timestamp for each miner / worker in API#4
Open
mkrufky wants to merge 1 commit intoVerusCoin:masterfrom
Open
Expose last share timestamp for each miner / worker in API#4mkrufky wants to merge 1 commit intoVerusCoin:masterfrom
mkrufky wants to merge 1 commit intoVerusCoin:masterfrom
Conversation
|
The last share timestamp data has been merged in #3 . This PR can be closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a re-send of PR #3 , as per @miketout 's request. We believe this PR was closed by accident.
It's useful in a UI to have the timestamp of the last share for every miners' workers.
The current s-nomp API does not expose this information, but it is stored in redis.
Let's expose it in the API.
Until now, I had to fudge the "last share" data for my pool, each worker seemed to be in sync:

After applying this patch, I have better detail in the API:
{ "RRNHfxjNaJ9zC7FYcYCVPuXLPpk9Vs3hFu.voskcoin": { "lastShare": 1563672761500, "name": "RRNHfxjNaJ9zC7FYcYCVPuXLPpk9Vs3hFu.voskcoin", "diff": 2663892268, "shares": 8129554.041592247, "invalidshares": 325182.16166369, "currRoundShares": 8249087416.608933, "currRoundTime": 233703.447, "hashrate": 116387229132344.4, "hashrateString": "232.77 MH/s", "luckDays": "1.452", "luckHours": "34.859", "paid": 0, "balance": 0 }, "RRNHfxjNaJ9zC7FYcYCVPuXLPpk9Vs3hFu.voskcoin2": { "lastShare": 1563672772522, "name": "RRNHfxjNaJ9zC7FYcYCVPuXLPpk9Vs3hFu.voskcoin2", "diff": 281319519, "shares": 824178.2783126401, "invalidshares": 0, "currRoundShares": 630672034.5685258, "currRoundTime": 233703.447, "hashrate": 11799395838087.918, "hashrateString": "23.60 MH/s", "luckDays": "14.327", "luckHours": "343.846", "paid": 0, "balance": 0 } }Pool UI now shows individual share times from each worker:

screenshots taken from the VerusCoin mining pool at verus.wattpool.net
upstream pr: s-nomp#144