-
Notifications
You must be signed in to change notification settings - Fork 194
upgraded tools in makefile #1769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
a821fa5 to
c84f178
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 issues found across 11 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="api/operator/v1beta1/vmauth_types.go">
<violation number="1" location="api/operator/v1beta1/vmauth_types.go:226">
P2: Validation ignores src_headers. A URL map that only sets src_headers will still fail the “at least one must be defined” check because SrcHeaders isn’t included in the condition. Include SrcHeaders in the empty check to match the error message and intended behavior.</violation>
</file>
<file name="docs/templates/api/type.tpl">
<violation number="1" location="docs/templates/api/type.tpl:37">
P3: Use a valid HTML line break tag instead of `</br>`; `<br/>` is the correct void element syntax.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
3e6c3ea to
2eb62fc
Compare
That seems to duplicate CHANGELOG functionality. Also, our docs are for the latest released version only, so this tag is useless for docs too. What other purposes for this tag do you see? |
it's hard to check changelog each time you need to enable a new property |
2eb62fc to
f67f1c2
Compare
updated all tools in makefile

replaced
Deprecated:prefixed comments with customdeprecatedmarkers that are rendered as shown below@makasim @vrutkovs what do you think about adding the same
+releasedmarker to inform about release since which parameter is available?Summary by cubic
Upgraded build tools and improved API/CRD docs by switching to custom deprecated markers and a pinned crd-ref-docs fork. Also increased doc render depth and regenerated client/informer code to v0.35 with context-aware watch support.
Refactors
Dependencies
Written for commit f67f1c2. Summary will update on new commits.