Skip to content

Conversation

@AndrewChubatiuk
Copy link
Contributor

@AndrewChubatiuk AndrewChubatiuk commented Jan 29, 2026

updated all tools in makefile
replaced Deprecated: prefixed comments with custom deprecated markers that are rendered as shown below
image

@makasim @vrutkovs what do you think about adding the same +released marker to inform about release since which parameter is available?


Summary by cubic

Upgraded build tools and improved API/CRD docs by switching to custom deprecated markers and a pinned crd-ref-docs fork. Also increased doc render depth and regenerated client/informer code to v0.35 with context-aware watch support.

  • Refactors

    • Replaced “Deprecated:” comments with +deprecated markers (with values) and updated the doc template to render deprecation notes.
    • Updated docs generation: added --max-depth=60, set Kubernetes version to 1.35, regenerated CRDs (controller-gen v0.20.0) and docs.
    • Regenerated clients/informers/listers to v0.35: moved to cache.ToListWatcherWithWatchListSemantics, added context-aware List/Watch, updated fake client to pass ListOptions and declare unsupported WatchList semantics, and simplified setConfigDefaults.
  • Dependencies

    • Bumped tool versions: kustomize, controller-tools, envtest, golangci-lint, codegenerator, kind, OLM, operator-sdk, OPM, yq, ginkgo.
    • Switched crd-ref-docs to github.com/AndrewChubatiuk/crd-ref-docs and pinned.
    • CI: install libgpgme-dev in GitHub Actions before tests.

Written for commit f67f1c2. Summary will update on new commits.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 issues found across 11 files

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="api/operator/v1beta1/vmauth_types.go">

<violation number="1" location="api/operator/v1beta1/vmauth_types.go:226">
P2: Validation ignores src_headers. A URL map that only sets src_headers will still fail the “at least one must be defined” check because SrcHeaders isn’t included in the condition. Include SrcHeaders in the empty check to match the error message and intended behavior.</violation>
</file>

<file name="docs/templates/api/type.tpl">

<violation number="1" location="docs/templates/api/type.tpl:37">
P3: Use a valid HTML line break tag instead of `</br>`; `<br/>` is the correct void element syntax.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

@AndrewChubatiuk AndrewChubatiuk force-pushed the upgrade-tools branch 4 times, most recently from 3e6c3ea to 2eb62fc Compare January 30, 2026 08:10
@makasim
Copy link
Member

makasim commented Jan 30, 2026

@makasim @vrutkovs what do you think about adding the same +released marker to inform about release since which parameter is available?

It's reasanoble to have it in general. Though I might not know all the specifics of the operator repository development process

@vrutkovs
Copy link
Collaborator

what do you think about adding the same +released marker to inform about release since which parameter is available?

That seems to duplicate CHANGELOG functionality. Also, our docs are for the latest released version only, so this tag is useless for docs too. What other purposes for this tag do you see?

@AndrewChubatiuk
Copy link
Contributor Author

AndrewChubatiuk commented Jan 30, 2026

That seems to duplicate CHANGELOG functionality. Also, our docs are for the latest released version only, so this tag is useless for docs too. What other purposes for this tag do you see?

  • people may use not up to date docs for opertor/k8s-stack installation, where operator may lack properties described in API.
  • those who already uses k8s-stack/operator of old version and would like to enable some functionality on CR using property

it's hard to check changelog each time you need to enable a new property

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants