-
Notifications
You must be signed in to change notification settings - Fork 5
chore(isolation-forest): Remove .dll, .so, .o files #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughUpdated .gitignore to add patterns for object and shared library files: Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.gitignore (1)
9-11: Scope ignores to src/ and add common R build artifactsGlobal
*.o/*.so/*.dllcan hide legitimate binary assets (e.g., under inst/). Prefer scoping to compiled outputs and ignore R check dirs.Apply:
-*.o -*.so -*.dll +src/**/*.o +src/**/*.so +src/**/*.dll +# Legacy Windows build dirs produced by R +src-i386/** +src-x64/** +# R CMD check output +*.Rcheck/Confirm you don't intentionally track any binaries under inst/ before scoping.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (3)
src/MSstatsConvert.sois excluded by!**/*.sosrc/RcppExports.ois excluded by!**/*.osrc/isolation_forest.ois excluded by!**/*.o
📒 Files selected for processing (1)
.gitignore(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build
Summary by CodeRabbit