Simplify Clone impl #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vonr
reviewed
Mar 28, 2024
| let mut data = Vec::with_capacity(self.meta.iter().map(|m| m.len).sum()); | ||
| let mut meta = Vec::with_capacity(self.meta.len()); | ||
|
|
||
| for bytes in self.iter() { |
Owner
There was a problem hiding this comment.
The reason this was done this way was to trim on clones - which is fine imo because Clone does not require a byte-for-byte copy. This is unrelated by my main concern with this function was actually whether i should bother making an extend_from_slice_unchecked lol.
Contributor
Author
There was a problem hiding this comment.
This seems to violate the principle of least surprise. I wouldn't assume a clone implementation to trim
Owner
There was a problem hiding this comment.
That's fair, but I wouldn't expect a clone of something to also clone useless bytes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't see why Clone is implemented weirdly, so I implemented it just in terms of Vec::clone. This also adds clone_from, which is why I didn't use the derive macro.