Skip to content

Fix: Add kernel version check for unaligned header inclusion #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KodzghlyCZ wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: Add kernel version check for unaligned header inclusion #34

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion driver/ch9344.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,12 @@
#include <linux/timer.h>
#include <linux/kfifo.h>
#include <asm/byteorder.h>
#include <asm/unaligned.h>

#if LINUX_VERSION_CODE < KERNEL_VERSION(6, 12, 0)
Copy link

@fqidz fqidz Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Recommend using >= to match with the style of the rest of the file. But other than that, LGTM.

#if (LINUX_VERSION_CODE >= KERNEL_VERSION(6, 12, 0))
...

#include <asm/unaligned.h> // For kernels before 6.12
#else
#include <linux/unaligned.h> // For kernels 6.12 and above
#endif

#if (LINUX_VERSION_CODE >= KERNEL_VERSION(4, 11, 0))
#include <linux/sched/signal.h>
Expand Down