Skip to content

Conversation

@jtgrasb
Copy link
Contributor

@jtgrasb jtgrasb commented Nov 17, 2025

This PR restores the broken PTO library link for the desalination case by moving the inertia block outside of the PTO and extracting the velocity within the Piston & RO subsystem. See also updated degenerate mass docs in WEC-Sim PR#1595.

While investigating the degenerate mass issues, I found that the inertia block could be moved outside the PTO block itself while still avoiding the degenerate mass errors. This does change the location of the mass depending on the PTO location and initial displacement, but this effect is small for a small mass. For small mass values (which should be used for resolving degenerate mass anyway), the difference in results is negligible between locating the inertia block inside vs. outside the PTO:

image image

Copy link
Contributor

@akeeste akeeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jtgrasb This is working for me. Approved and merging!

@akeeste akeeste merged commit 7cca796 into WEC-Sim:dev Dec 11, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants