Restore broken library link for desalination case #102
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR restores the broken PTO library link for the desalination case by moving the inertia block outside of the PTO and extracting the velocity within the Piston & RO subsystem. See also updated degenerate mass docs in WEC-Sim PR#1595.
While investigating the degenerate mass issues, I found that the inertia block could be moved outside the PTO block itself while still avoiding the degenerate mass errors. This does change the location of the mass depending on the PTO location and initial displacement, but this effect is small for a small mass. For small mass values (which should be used for resolving degenerate mass anyway), the difference in results is negligible between locating the inertia block inside vs. outside the PTO: