Pull bugfixes from main into dev #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* try to update libraries again * fix simscapeinstrumentationlogging error --------- Co-authored-by: akeeste <akeeste@sandia.gov>
* remove MCR run from OWC test * install moordyn for paraview RM3 tests so that it isnt skipped * exclude linux for paraview test (RM3 has moordyn) * remove comment from paraview RM3 test * resave RM3MooringMatrix.slx to avoid simscape logging error * fix linux-moordyn exclusion * fix plotting in passive yaw regression * remove annoying extra spaces * update the correct passive yaw results that are compared against * remove debugging comment in runLoadPassiveYawIrr.m * remove MOST regression tests * updating to MATLAB R2024a * updating slx to 2023b for oswec paraview * skip mooring and paraview tests --------- Co-authored-by: Ruehl <kmruehl@sandia.gov>
Contributor
Author
|
This is in progress locally. I will push the changes once all the tests pass locally |
Contributor
Author
|
Upon merge, one of the moordyn cases is failing but not the others strangely. It runs locally and I'm trying to get it to pass on reruns. Edit: this might be because of simu.cicDt. I didn't realize that was an intentional change in #95. I just remade that change and pushed it to dev directly |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull bugfixes from main into dev: