Fixed Slice-Plots of Tetrahedra with Plane #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjaap
requested changes
Apr 16, 2025
Member
|
Thanks for fixing this annoying bug 😃 Please see my comments and squash the commits into one in the end. |
Liameloy
force-pushed
the
dev/tetrahedronSliceFixing
branch
from
9895c27 to
1e9a70c
Compare
Member
|
before:
with this fix:
Thanks for the improvement! |
pjaap
approved these changes
Apr 16, 2025
Member
pjaap
left a comment
pjaap
left a comment
There was a problem hiding this comment.
Will merge when last comment is done.
Fixed error in tet_x_plane function in marching.jl which incorrectly assessed intersections between tetrahedron edges and plane
Liameloy
force-pushed
the
dev/tetrahedronSliceFixing
branch
from
1e9a70c to
a7961ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using slice_plot to view the cross-section of a given grid with a given plane, the resulting images had "holes" or missing shapes.
This was seemingly caused by a problem in tet_x_plane!() in marching.jl and should now be fixed.