fix: Ensure rest parameter starts consuming at segment start #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue (#182) where the rest parameter regex pattern was incorrectly matching similar text in paths. The fix ensures that rest parameters only consume path segments starting with a forward slash.
Key changes:
- Updated rest parameter regex pattern to require a leading slash (
\\/.*instead of.*) - Updated all test expectations to reflect the new pattern behavior
- Added new test cases to verify the fix handles edge cases correctly
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/lib/kernel/RouteHelper.svelte.ts | Modified rest parameter regex replacement to require leading slash |
| src/lib/kernel/RouteHelper.svelte.test.ts | Updated existing test expectations and added new test cases for edge cases |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #182.