Skip to content

ci: merge unit-tests into lint-typecheck job #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jakebromberg wants to merge 1 commit into
base: ci/skip-redundant-build
Choose a base branch
from
Open

ci: merge unit-tests into lint-typecheck job #160

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 6 additions & 43 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,14 +95,16 @@ jobs:
echo "run-integration=false" >> $GITHUB_OUTPUT
fi

# Fast lint and type check - always runs on code changes
lint-and-typecheck:
# Lint, type check, and unit tests - always runs on code changes
lint-typecheck-and-unit-tests:
needs: detect-changes
if: needs.detect-changes.outputs.src == 'true'
runs-on: ubuntu-latest
steps:
- name: Checkout Code
uses: actions/checkout@v4
with:
fetch-depth: 0 # Need full history for --changedSince

- name: Set Up Node.js
uses: actions/setup-node@v4
Expand Down Expand Up @@ -144,45 +146,6 @@ jobs:
- name: Build
run: npm run build

# Unit tests - runs affected tests only
unit-tests:
needs: detect-changes
if: needs.detect-changes.outputs.src == 'true'
runs-on: ubuntu-latest
steps:
- name: Checkout Code
uses: actions/checkout@v4
with:
fetch-depth: 0 # Need full history for --changedSince

- name: Set Up Node.js
uses: actions/setup-node@v4
with:
node-version: '20'

- name: Cache node_modules
id: cache-node-modules
uses: actions/cache@v4
with:
path: node_modules
key: node-modules-${{ runner.os }}-node20-${{ hashFiles('package-lock.json') }}

- name: Validate cached node_modules
id: validate-cache
if: steps.cache-node-modules.outputs.cache-hit == 'true'
run: |
if npm ls --depth=0 >/dev/null 2>&1; then
echo "valid=true" >> $GITHUB_OUTPUT
else
echo "valid=false" >> $GITHUB_OUTPUT
echo "⚠️ Cache corrupted, will reinstall"
rm -rf node_modules
fi

- name: Install Dependencies
if: steps.cache-node-modules.outputs.cache-hit != 'true' || steps.validate-cache.outputs.valid == 'false'
run: npm ci

- name: Run affected unit tests
run: |
if [ "${{ github.event_name }}" = "pull_request" ]; then
Expand All @@ -203,8 +166,8 @@ jobs:
# Integration tests - only when backend/auth/shared changes
# Note: Job always runs to report status, but steps are skipped when no relevant changes
Integration-Tests:
needs: [detect-changes, lint-and-typecheck]
# Run when lint-and-typecheck succeeds or was skipped (no src changes).
needs: [detect-changes, lint-typecheck-and-unit-tests]
# Run when lint-typecheck-and-unit-tests succeeds or was skipped (no src changes).
# This ensures the required check reports status on docs-only PRs.
if: ${{ !failure() && !cancelled() }}
runs-on: ubuntu-latest
Expand Down