Feat: 2.4 seedless multi srp update #25
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: smgv <gpatra1996@gmail.com>
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
ieow
changed the base branch from
feat/change-password-biometric
to
feat/seedless-change-password
ieow
force-pushed
the
feat/seedless-change-password
branch
from
bfb6ccf to
33a563a
Compare
ieow
force-pushed
the
feat/seedless-multi-srp-update
branch
from
5d47c54 to
6520826
Compare
ieow
changed the title
… onboarding journey
…ddition, and seed phrase fetching
…tion for improved tracking feat: Add tracing for auth related ops
…arding flow to ensure traces are ended at the most appropriate points feat: A new trace OnboardingCreateKeyAndBackupSrp is introduced to specifically track the creation and backup of the SRP, and the existing OnboardingAddSrp trace is now used exclusively for adding a new SRP.
ieow
changed the title
…ross multiple components
… ChoosePassword, ImportFromSecretRecoveryPhrase, and Login components as the traces are ended when the component dismounts
chore: Sentry Performance Tracing for Onboarding Flows
…d end at their respective components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Multi-SRP synced with Seedless Onboarding
-> Add SRP-A to seedless onboarded device A
-> Rehydrate on device B with SRP-A
Screen.Recording.2025-05-10.at.11.44.06.AM.mov
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist