feat: 1.4 new srp ui import existing wallet #35
Conversation
Co-authored-by: smgv <gpatra1996@gmail.com>
Co-authored-by: smgv <gpatra1996@gmail.com>
Co-authored-by: smgv <gpatra1996@gmail.com>
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
…/Web3Auth/metamask-mobile into feat/srp-onboarding-carousel-tnc
|
I have read the CLA Document and I hereby sign the CLA |
…/Web3Auth/metamask-mobile into feat/srp-onboarding-carousel-tnc
| </View> | ||
| ) | ||
| : null, | ||
| // headerBackTitle: strings('navigation.back'), |
There was a problem hiding this comment.
It is replace with headerLeft
the commented code is removed
e0de428abfefd66b113548edd94235190d134566
| const innerStyles = StyleSheet.create({ | ||
| headerStyle: { | ||
| backgroundColor: themeColors.background.default, | ||
| backgroundColor: color || themeColors.background.default, |
There was a problem hiding this comment.
We use a lot of the name color in the params and we only use it for the backgroundColor, would be more accurate to rename it?
| const innerStyles = StyleSheet.create({ | ||
| headerStyle: { | ||
| backgroundColor: themeColors.background.default, | ||
| backgroundColor: color || themeColors.background.default, |
There was a problem hiding this comment.
We use a lot of the name color in the params and we only use it for the backgroundColor, would be more accurate to rename it?
| StyleSheet.create({ | ||
| scroll: { | ||
| flex: 1, | ||
| // marginTop: 100, |
| import Routes from '../../../constants/navigation/Routes'; | ||
| import { selectAccounts } from '../../../selectors/accountTrackerController'; | ||
| import trackOnboarding from '../../../util/metrics/TrackOnboarding/trackOnboarding'; | ||
| import { trace, TraceName, TraceOperation } from '../../../util/trace'; |
There was a problem hiding this comment.
Nice catch this seemed to be forgotten here, thank you!
| ); | ||
| }; | ||
|
|
||
| const termsOfUse = async () => { |
There was a problem hiding this comment.
Something doesn't add up, this PR have the same changes of this one although the branch of this PR is branching off it!
Can we solve this issue to facilitate review? This will make it a bit harder to understand the final result of the code
| BVLinearGradient: cb006ba232a1f3e4f341bb62c42d1098c284da70 | ||
| CocoaAsyncSocket: 065fd1e645c7abab64f7a6a2007a48038fdc6a99 | ||
| DoubleConversion: f16ae600a246532c4020132d54af21d0ddb2a385 | ||
| DoubleConversion: 5189b271737e1565bdce30deb4a08d647e3f5f54 |
Description
1.4
Update New SRP onboarding flow as per figma design
https://www.figma.com/design/pViOUcmjwhEzFsdrwknpNc/Onboarding-redesign?node-id=434-55200&t=wmEoQSF9g9lFtkwp-0
This PR is part 4 of 7 for the new SRP ui update
This PR cover
Screen.Recording.2025-05-21.at.10.18.02.AM.mov
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist