-
Notifications
You must be signed in to change notification settings - Fork 252
feat: update wagmi permissionless and viem #2341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lionellbriones
wants to merge
9
commits into
master
Choose a base branch
from
feat/update-wagmi
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
d26c9d3
update wagmi to v3
lionellbriones d671c9c
missed deprecated wagmi exports
lionellbriones b38537a
update viem and permissionless
lionellbriones 46d031d
update viem peer dependency
lionellbriones 1fa1285
update package-lock
lionellbriones fb9b068
update nextjs 14
lionellbriones 8c0215a
nextjs 15
lionellbriones af377d0
update nextjs demo to 16
lionellbriones ae93ea4
minor dependency updates
lionellbriones File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| import { defineConfig, globalIgnores } from "eslint/config"; | ||
| import nextCoreWebVitals from "eslint-config-next/core-web-vitals"; | ||
| import path from "node:path"; | ||
| import { fileURLToPath } from "node:url"; | ||
|
|
||
| const __filename = fileURLToPath(import.meta.url); | ||
| const __dirname = path.dirname(__filename); | ||
|
|
||
| export default defineConfig([globalIgnores(["**/*.config.js"]), { | ||
| extends: [...nextCoreWebVitals], | ||
| }]); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,6 @@ | ||
| /// <reference types="next" /> | ||
| /// <reference types="next/image-types/global" /> | ||
| import "./.next/dev/types/routes.d.ts"; | ||
|
|
||
| // NOTE: This file should not be edited | ||
| // see https://nextjs.org/docs/basic-features/typescript for more information. | ||
| // see https://nextjs.org/docs/app/api-reference/config/typescript for more information. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong hook used for account address and connection status
Medium Severity
The migration from
useAccounttouseConnectionmay be incorrect. According to wagmi documentation,useAccountis the hook for getting account information includingaddressandisConnected. TheuseConnectionhook has a different purpose and return type. The Vue demo uses{ status, address }fromuseConnection(withstatus, notisConnected), suggesting the React code's attempt to destructureisConnectedfromuseConnectionmay not work correctly, potentially causing the wagmi connection status to always appear disconnected.Additional Locations (1)
demo/nextjs-ssr-app/components/Main.tsx#L14-L15