-
Notifications
You must be signed in to change notification settings - Fork 252
Refactor: W3APD-5238 - migrate from @solana/web3.js to @solana/kit #2347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
- Replace Connection with RPC client from @solana/kit - Update transaction types to use @solana/kit's Transaction - Remove @toruslabs/bs58 in favor of @solana/kit's base58 utilities - Update demo app to use new Solana utilities BREAKING CHANGE: connection property renamed to rpc, transaction types now expect compiled Transaction from @solana/kit
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
8c378ae to
4c2564b
Compare
| } | ||
| }; | ||
|
|
||
| export const signAndSendTransaction = async (provider: IProvider, uiConsole: any) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clean up as these functions are not used
| import { generateSolTransferInstruction, generateVersionedTransaction } from "../utils/solana"; | ||
|
|
||
| // EVM | ||
| export const walletSignPersonalMessage = async ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clean up as these functions are not used
|
@cursor review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
|
bugbot run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
BREAKING CHANGE: connection property renamed to rpc, transaction types now expect compiled Transaction from @solana/kit
Motivation and Context
Jira Link:
Description
How has this been tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Note
Migrates Solana stack to
@solana/kit, standardizing RPC access and transaction types across packages and the demo app.@solana/web3.jswith@solana/kit; adds@solana-program/systemfor SOL transfer instructionsSolanaWalletto usecreateSolanaRpc, exposerpc(wasconnection), and require compiledTransactionfrom@solana/kit@solana/kitcodecs (base58/base64) and transaction (de)serialization helpersutils/solanato generate transfer instructions and legacy/versioned transactions; dashboard actions now userpc; simplifiedsolHandlers; removes legacywalletServiceHandlers@web3auth/modalto10.13.2, updates deps/peerDeps to@solana/kitBREAKING:
connection→rpc; Solana APIs now accept@solana/kitTransaction.Written by Cursor Bugbot for commit e8f9e45. This will update automatically on new commits. Configure here.