-
Notifications
You must be signed in to change notification settings - Fork 252
fix: empty login modal in external wallet only mode #2348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
what's the context of this pr? |
Bug: When initializing Web3Auth with AUTH connector hidden (external wallets only mode), the modal appears empty on first open. Close and reopen → wallets appear. Example: Screen.Recording.2026-01-26.at.19.21.12.mov |
|
Original condition:
Problem:
New condition:
Why it works:
|
|
@cursor review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Motivation and Context
Jira Link:
NA
Description
This PR changes:
How has this been tested?
Screenshots (if appropriate):
Before:
https://github.com/user-attachments/assets/af88d9ef-dfa2-4f57-8634-884eb4c9c287
After:
https://github.com/user-attachments/assets/ab9abf04-8378-469f-9682-230c9b88c984
Types of changes
Checklist:
Note
Resolves empty modal when using external-wallet-only mode and streamlines post-connect UX.
Root.tsxto renderConnectWalletwhenPAGES.CONNECT_WALLETand either external page isn’t shown orisExternalWalletModeOnlyis true, fixing the empty modal stateLoader.tsxto immediately close on external wallet connect (0 ms) while keeping a 1s delay for social loginsExternalWalletOnlyTest.vueto exercise isolated external-wallet flow; hides main connect button on that tab@web3auth/modalto10.13.1and@web3auth/no-modalto10.13.0in demo lockfileWritten by Cursor Bugbot for commit 4f93318. This will update automatically on new commits. Configure here.