fix: updated bottomsheet for walletregistry app #2349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
packages/modal/src/ui/components/ConnectWallet/ConnectWalletQrCode/ConnectWalletQrCode.tsx
Show resolved
Hide resolved
| selectedButton={bodyState.metamaskQrCode.wallet} | ||
| primaryColor={bodyState.metamaskQrCode.wallet.walletRegistryItem?.primaryColor} | ||
| logoImage={`https://images.web3auth.io/login-${bodyState.metamaskQrCode.wallet.name}.${bodyState.metamaskQrCode.wallet.imgExtension}`} | ||
| platform={deviceDetails.platform} |
There was a problem hiding this comment.
Missing disableBackButton prop in MetaMask QR code view
Medium Severity
The ConnectWalletHeader in the MetaMask QR code view is missing the disableBackButton prop. The PR adds disableBackButton={bodyState.installLinks?.show || bodyState.multiChainSelector?.show} to the main ConnectWallet component, but the ConnectWalletHeader rendered when bodyState.metamaskQrCode?.show is true doesn't receive this prop. When a user opens the "Get Wallet" install links bottom sheet from the MetaMask QR code view, the back button remains enabled instead of being disabled, which is inconsistent with the stated PR behavior.
Additional Locations (1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Jira Link:
Description
In this PR, I have updated the ConnectWalletQRCode handling for wallet links. The component is no longer rendered when the walletRegistry app list is empty. Additionally, we now validate platform-specific keys—browser for desktop and ios/android for mobile—to ensure the correct platforms are available.
We also disabled the back button when the bottom sheet is opened.
How has this been tested?
Screenshots (if appropriate):
Screen.Recording.2026-01-27.at.5.53.42.PM.mov
Types of changes
Checklist:
Note
Refines wallet connection UX and bottom sheet behavior.
ConnectWalletQrCodenow shows the "Get wallet" CTA only when wallet registry has platform-appropriate links (desktop:browser/chrome/firefox/edge, mobile:ios/android); requires and usesplatformprop passed fromRootandConnectWalletConnectWalletHeaderAPI updated: addshideBackButton; back button respectsdisableBackButton(disabled state and click ignored);ConnectWalletcomputeshideBackButtonand forwardsdisableBackButtonfromRoot(disabled wheninstallLinksormultiChainSelectorsheets are open)BottomSheetbackdrop click now stops event propagation before closing to avoid accidental parent handlersWritten by Cursor Bugbot for commit 470d069. This will update automatically on new commits. Configure here.