interpreter: fix function start offset of metadata.code.branch_hint #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuri91
force-pushed
the
fix_function_offset
branch
from
058607a to
ba3e7ca
Compare
rossberg
reviewed
May 8, 2025
rossberg
reviewed
May 8, 2025
Collaborator
Author
|
@rossberg thanks for having a look. I was wondering: are these latest additions to this fork inconvenient for your work on the Wasm 3.0 branch? |
Member
|
I think it's fine here. Since this does not touch any code that was changed upstream, it should merge cleanly. |
The source information of functions consider them starting from the first byte of their size, while code metadata sections consider the start to be the first byte after the size, so we have to account for that. Co-authored-by: Andreas Rossberg <rossberg@mpi-sws.org>
yuri91
force-pushed
the
fix_function_offset
branch
from
e8b530e to
020593d
Compare
Collaborator
Author
|
I added @kripken 's test case to the tests as a binary. It fails before this PR and passes now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The source information of functions consider them starting from the first byte of their size, while code metadata sections consider the start to be the first byte after the size, so we have to account for that.