-
Notifications
You must be signed in to change notification settings - Fork 172
Add AudioPlayoutStats interface #2645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
hoch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good with some nits.
Also could you wrap the text at the column 80?
From @hoch Co-authored-by: Hongchan Choi <hongchan.choi@gmail.com>
|
Implemented your comments and wrapped the lines at 80 (except where it would have cut through a link, which seems to be the standard for the rest of the document), thanks! |
hoch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
|
@padenot Could you take a look? |
Co-authored-by: Christoph Guttandin <chrisguttandin@media-codings.com>
padenot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments.
Co-authored-by: Paul Adenot <paul@paul.cx>
Co-authored-by: Paul Adenot <paul@paul.cx>
f36f524 to
92be88e
Compare
92be88e to
3d037e7
Compare
3d037e7 to
427a7d5
Compare
Hernqvist
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review!
|
Thanks for addressing all my comments, and sorry for the delay. |
|
@padenot Thanks for the review! Does your last comment mean that you approve this change? (Somehow missed to click "approve") |
Integrates the Playout Statistics API for WebAudio spec into the WebAudio spec.
The following changes are made between the version incubated in WICG and this PR:
Related issue: #2642
Preview | Diff