Skip to content

Conversation

@Hernqvist
Copy link

@Hernqvist Hernqvist commented Sep 16, 2025

Integrates the Playout Statistics API for WebAudio spec into the WebAudio spec.

The following changes are made between the version incubated in WICG and this PR:

  • "fallback"/"fallbackFrames" terminology is replaced with "underrun".
  • Duration types are changed from DOMHighResTimestamp to double.
  • Time units are changed from milliseconds to seconds.

Related issue: #2642


Preview | Diff

Copy link
Member

@hoch hoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good with some nits.

Also could you wrap the text at the column 80?

@Hernqvist
Copy link
Author

Implemented your comments and wrapped the lines at 80 (except where it would have cut through a link, which seems to be the standard for the rest of the document), thanks!

Copy link
Member

@hoch hoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@hoch hoch requested a review from padenot September 18, 2025 15:58
@hoch
Copy link
Member

hoch commented Sep 18, 2025

@padenot Could you take a look?

Co-authored-by: Christoph Guttandin <chrisguttandin@media-codings.com>
Copy link
Member

@padenot padenot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments.

Hernqvist and others added 2 commits September 30, 2025 16:40
Co-authored-by: Paul Adenot <paul@paul.cx>
Co-authored-by: Paul Adenot <paul@paul.cx>
@Hernqvist Hernqvist force-pushed the playoutstats branch 2 times, most recently from f36f524 to 92be88e Compare October 13, 2025 14:56
Copy link
Author

@Hernqvist Hernqvist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review!

@padenot
Copy link
Member

padenot commented Dec 9, 2025

Thanks for addressing all my comments, and sorry for the delay.

@hoch
Copy link
Member

hoch commented Dec 9, 2025

@padenot Thanks for the review! Does your last comment mean that you approve this change?

(Somehow missed to click "approve")

@hoch hoch requested a review from padenot December 9, 2025 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants