fixed warning for state changes for unmounted component #9
Open
Arvind90475 wants to merge 5 commits intoWebDevSimplified:masterfrom
Open
fixed warning for state changes for unmounted component #9Arvind90475 wants to merge 5 commits intoWebDevSimplified:masterfrom
Arvind90475 wants to merge 5 commits intoWebDevSimplified:masterfrom
Conversation
|
Thank you! I was banging my head around trying to figure out where the warning was coming from. |
|
You're a genius! I was soooo frustrated for not being able to fix that issue. Thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Login and signup component after the history.push() , state is being updated which causes the warning that unmounted component's state cannot be updated. It is happening because of the setLoading outside the try catch block.
I have moved the setLoading before the history.push() to fix this.
cheers