Skip to content

Comments

feat: Added getSupportedDataTypes#126

Merged
usernane merged 3 commits intomainfrom
dev
Feb 10, 2026
Merged

feat: Added getSupportedDataTypes#126
usernane merged 3 commits intomainfrom
dev

Conversation

@usernane
Copy link
Member

@usernane usernane commented Feb 10, 2026

Summary

Centralized the definition of supported data types for each database engine.

Motivation

Single source of trust

Changes

This pull request has following changes:

  • Added getSupportedDataTypes() to the class DataTypes
  • Refactored MySQLColumn and MSSQLColumn to use the method DataTypes::getSupportedDataTypes()
  • Updated test cases as needed

How to test / verify

Describe testing approach, if it uses unit tests, integration or manual.

  • Unit tests: Updated test cases for both MySQLColumn and MSSQLColumn

Breaking changes

  • No breaking changes
  • Yes (describe + migration notes below)

Migration notes (required if breaking)

N/A

Checklist

  • My commits follow Conventional Commits
  • The title of the pull request follow Conventional Commits
  • I added/updated tests (or explained why not)
  • I updated docs (if needed)
  • I ran lint/cs-fixer (if applicable)
  • I considered backward compatibility and security

Related issues

This pull request will close following issues:
N/A

@codecov
Copy link

codecov bot commented Feb 10, 2026

Codecov Report

❌ Patch coverage is 7.10059% with 157 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.14%. Comparing base (aa9de3e) to head (3eec245).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...ebFiori/Database/Repository/AbstractRepository.php 1.33% 148 Missing ⚠️
...iori/Database/Attributes/AttributeTableBuilder.php 42.85% 4 Missing ⚠️
WebFiori/Database/MsSql/MSSQLQuery.php 0.00% 4 Missing ⚠️
WebFiori/Database/Entity/EntityGenerator.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #126      +/-   ##
============================================
- Coverage     74.30%   74.14%   -0.16%     
- Complexity     2086     2087       +1     
============================================
  Files            53       53              
  Lines          5234     5198      -36     
============================================
- Hits           3889     3854      -35     
+ Misses         1345     1344       -1     
Flag Coverage Δ
php-8.1 74.86% <7.36%> (+0.01%) ⬆️
php-8.2 74.63% <7.36%> (+0.01%) ⬆️
php-8.3 73.98% <7.10%> (-0.16%) ⬇️
php-8.4 73.98% <7.10%> (-0.16%) ⬇️
php-8.5 73.98% <7.10%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud
Copy link

@usernane usernane merged commit c1af0df into main Feb 10, 2026
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant