Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #126 +/- ##
============================================
- Coverage 74.30% 74.14% -0.16%
- Complexity 2086 2087 +1
============================================
Files 53 53
Lines 5234 5198 -36
============================================
- Hits 3889 3854 -35
+ Misses 1345 1344 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Centralized the definition of supported data types for each database engine.
Motivation
Single source of trust
Changes
This pull request has following changes:
getSupportedDataTypes()to the classDataTypesMySQLColumnandMSSQLColumnto use the methodDataTypes::getSupportedDataTypes()How to test / verify
Describe testing approach, if it uses unit tests, integration or manual.
MySQLColumnandMSSQLColumnBreaking changes
Migration notes (required if breaking)
N/A
Checklist
Related issues
This pull request will close following issues:
N/A