Created user info page prototype, update package.json and add side menu.#14
Open
rakotoz wants to merge 1 commit intoWebPurple:masterfrom
Open
Created user info page prototype, update package.json and add side menu.#14rakotoz wants to merge 1 commit intoWebPurple:masterfrom
rakotoz wants to merge 1 commit intoWebPurple:masterfrom
Conversation
eugrdn
reviewed
Dec 17, 2018
| "react": "16.5.0", | ||
| "react-native": "0.57.2", | ||
| "react-native-cli": "2.0.1", | ||
| "react-native-side-menu": "^1.1.3", |
| @@ -0,0 +1,66 @@ | |||
| // @flow | |||
Member
There was a problem hiding this comment.
we don't use flow, use typescript instead
| } | ||
| }; | ||
|
|
||
| export default withNavigation(SideMenu) as React.ComponentType<Props>; No newline at end of file |
Member
There was a problem hiding this comment.
withNavigation is a generic function, use withNavigation<Props>(...) instead of type assertion, and pls, fix it in EventInfo.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.