Skip to content

Allow to add new things at runtime #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
0815fox wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Allow to add new things at runtime #151

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2489a59
Allow to add new things at runtime
0815fox Oct 9, 2021
65887c1
Merge remote-tracking branch 'upstream/master' into feature/runtime-a…
Oct 13, 2021
761fdf1
run prettier as requested
Oct 13, 2021
15d6826
removed linter warnings
Oct 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,14 @@ export class MultipleThings {
* @param {String} name The mDNS server name
*/
constructor(things: Thing[], name: string) {
this.things = things;
this.things = things.slice();
this.name = name;
}

addThing(thing: Thing): number {
return this.things.push(thing) - 1;
}

/**
* Get the thing at the given index.
*
Expand Down Expand Up @@ -848,6 +852,14 @@ export class WebThingServer {
this.server.on('request', this.app);
}

addThing(thing: Thing): void {
if (this.things instanceof SingleThing) {
throw new Error('Cannot add new things when Webthings was instanciated with a SingleThing.');
}
const i = this.things.addThing(thing);
thing.setHrefPrefix(`${this.basePath}/${i}`);
}

/**
* Start listening for incoming connections.
*
Expand Down