Use help-fns internal symbol completion table #364
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR came as a result of a package called llama that introduced a hacky macro that unfortunately results in an empty string function name that always appear at the top of the completion table.
The details of the problem is described here. Essentially, this macro abuses the fact that the empty string can be used as a symbol, which defeats every intuitive string matching and sorting algorithms, and results in an empty string function at the top of the completion table whenever
helpful-callableorhelpful-macrois invoked.Recent attempts to fix this problem relied on the fact that
describe-functioncallsall-completionsdown the call stack to filter this annoyance out, but helpful'shelpful--read-symbolsymbol uses theobarraydirectly without filtering. This PR addresses this issue by delegating tohelp--symbol-completion-tablewhen it's available (Emacs >= 26.1).