-
-
Notifications
You must be signed in to change notification settings - Fork 64
feat: Allow setting a price when adding an item to the wishlist #174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: Allow setting a price when adding an item to the wishlist #174
Conversation
|
I'm a fan of this change. |
|
I think this complicates the UI. Having a simple UI is very important to me because it makes the app accessible to people like relatives who might not be technically-minded. Having a big form in the way to add an item or even just too many things on screen can be overwhelming for some people. Three fields isn't a lot of fields, the current two is the optimal amount to have, at least by default. This doesn't add a lot of complexity from a maintenance perspective, so I'm happy to merge it if you want to lock it behind an environment variable or a switch in the user's settings. |
@JadElClemens - thoughts on putting this functionality behind an environment variable so people can turn it on/off as per their needs? |
|
No issue, just haven't had the time |
deb188d to
89b3456
Compare
|
This is now gated behind the |
If a price is given, it takes precedence over the price fetched from getProductData
e0cfb1b to
9ba741d
Compare

Adds a "Price" field below name/URL field in the "add item" section.
This is a common issue for me when creating my wishlist - if I'm not adding a URL, I always have to add the item and then go back into the edit dialog to set a price. It's not often that I'll want to add an item with no price.
If a price is given, it takes precedence over the price fetched from getProductData. Open to input on that behavior.
Note - I've chosen to use table layout for positioning here as I see it in many other places in the source, otherwise I may have chosen ex. flexbox.