Skip to content

Conversation

@JadElClemens
Copy link
Contributor

@JadElClemens JadElClemens commented Dec 29, 2024

Adds a "Price" field below name/URL field in the "add item" section.

image

This is a common issue for me when creating my wishlist - if I'm not adding a URL, I always have to add the item and then go back into the edit dialog to set a price. It's not often that I'll want to add an item with no price.

If a price is given, it takes precedence over the price fetched from getProductData. Open to input on that behavior.

Note - I've chosen to use table layout for positioning here as I see it in many other places in the source, otherwise I may have chosen ex. flexbox.

@JadElClemens
Copy link
Contributor Author

One potential issue -

image

Has this result on too-narrow screens when field labels wrap to multiple lines

@cj13579
Copy link
Contributor

cj13579 commented Dec 29, 2024

I'm a fan of this change. getProductData is good, but if you're using a site it doesn't support, it doesn't work, or in my case I want to update the currency, this is a pain that could be solved by this!

@JadElClemens JadElClemens marked this pull request as draft December 29, 2024 23:15
@JadElClemens JadElClemens marked this pull request as ready for review December 30, 2024 02:05
@Wingysam Wingysam changed the title Allow setting a price when adding an item to the wishlist feat: Allow setting a price when adding an item to the wishlist Jan 24, 2025
@Wingysam
Copy link
Owner

I think this complicates the UI. Having a simple UI is very important to me because it makes the app accessible to people like relatives who might not be technically-minded. Having a big form in the way to add an item or even just too many things on screen can be overwhelming for some people.

Three fields isn't a lot of fields, the current two is the optimal amount to have, at least by default. This doesn't add a lot of complexity from a maintenance perspective, so I'm happy to merge it if you want to lock it behind an environment variable or a switch in the user's settings.

@cj13579
Copy link
Contributor

cj13579 commented Mar 4, 2025

Three fields isn't a lot of fields, the current two is the optimal amount to have, at least by default. This doesn't add a lot of complexity from a maintenance perspective, so I'm happy to merge it if you want to lock it behind an environment variable or a switch in the user's settings.

@JadElClemens - thoughts on putting this functionality behind an environment variable so people can turn it on/off as per their needs?

@JadElClemens
Copy link
Contributor Author

No issue, just haven't had the time

@JadElClemens JadElClemens force-pushed the wishlist-add-item-with-price branch from deb188d to 89b3456 Compare December 31, 2025 07:00
@JadElClemens
Copy link
Contributor Author

This is now gated behind the WISHLIST_PRICE_FIELD env variable, which is false by default.

@JadElClemens JadElClemens force-pushed the wishlist-add-item-with-price branch from e0cfb1b to 9ba741d Compare December 31, 2025 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants