feat: Condense wishlist UI #201
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a slight Wishlist UI rework to remove (imo) unnecessary headers and considerably condense "action buttons" (pledge/unpledge, move, edit, and delete) in the mobile UI particularly. Incidentally, I have also tuned some of the wishlist table widths. and completely removed (not disabled) buttons for actions that are not allowed (i.e. delete or edit an item you did not add).
Here on, I'll use "standard UI" to mean a wide screen and "mobile UI" to mean a narrow screen. Overall, compressing the action buttons saves a considerable amount of vertical space on the mobile UI, making it much easier to get an overview of the whole list. On the stanrdard UI, we save a little bit of horizontal space - I have used this to slightly enlargen the name and description fields (I think).
Feedback Requested
I think that the meaning of the buttons is pretty easy to understand, but I can also forsee the need to keep the "move" buttons on one's own list separated into their own section (i.e. "Move Item") to further clarify their purpose. I could use some feedback on the placement/justification of items (pledge/unpledge on right, others on left - where applicable) and the new widths of columns.
I've also used mostly element-level styles. Not sure if any existing classes come close to what I've changed or what a better way to do this would be.
Alternatives
Instead of completely removing Delete and Edit when not allowed, it might be better to keep them present but disabled, and we can make the Pledge/Unpledge button match the width of the four move buttons that would be present on your own wishlist. That way the UI is a little more consistent.
Comparison
Own wishlist, standard UI
Before:
After:
Other's wishlist, standard UI
Before:
After:
Own wishlist, mobile UI
Before:
After:
Other's wishlist, mobile UI
Before:
After: