feat: Hide/show progress bars #44
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordigh
force-pushed
the
hide-show-progressbars
branch
from
f2307fb to
4bbf3c4
Compare
Progress bars are very visible at a glance. If your family members happen to look over your shoulder while you're working on Christmas lists, you may accidentally reveal to them how many gifts they're getting. Additionally, parents may want to log into their children's accounts for help and may not want to see their own progress bars from their children's accounts. Both situations have already happened in my family! So, let's hide the progress bars by default and provide an easy link to show them.
jordigh
force-pushed
the
hide-show-progressbars
branch
from
4bbf3c4 to
3ee7089
Compare
Owner
|
Thank you! This is a good idea and should be done by default, but an environment variable should restore the original functionality. ALWAYS_SHOW_PROGRESS_BARS=true should remove the button and always show progress bars. |
jordigh
force-pushed
the
hide-show-progressbars
branch
2 times, most recently
from
509d968 to
a391e27
Compare
This restores the previous behaviour.
jordigh
force-pushed
the
hide-show-progressbars
branch
2 times, most recently
from
e2353a2 to
0581171
Compare
Author
|
There, like that? |
Owner
|
Hey, sorry I haven't gotten to this yet. I've just gotten home from a fall retreat and need to catch up on homework. I'll review this when I can. Initial concerns are that the language definitions are still missing, and the env check should use the parse function of yes-no like this: const { parse: yesNo } = require('yes-no')Thanks! |
Owner
|
These two strings should still be localized when visible. "???/???" might not make sense in some languages, and it might make more sense to have some kind of text in the "name " string. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress bars are very visible at a glance. If your family members happen to look over your shoulder while you're working on Christmas lists, you may accidentally reveal to them how many gifts they're getting. Additionally, parents may want to log into their children's accounts for help and may not want to see their own progress bars from their children's accounts. Both situations have already happened in my family!
So, let's hide the progress bars by default and provide an easy button to show them.