Feature/wire 194 abigen support enum #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
requested changes
Oct 30, 2025
| // Use the enum's integer (underlying) type for storage mapping | ||
| td.type = translate_type(ED->getIntegerType()); | ||
| if (!td.new_type_name.empty() && !td.type.empty()) { | ||
| _abi.typedefs.insert(td); |
Contributor
There was a problem hiding this comment.
I don't see any tests for this.
Did you verify this works with abieos and abi_serializer of wire-sysio and WharfKit?
Collaborator
Author
There was a problem hiding this comment.
I did verify in abieos and a system contract depot, was the test point.
The problem with writing a test, is that the actual source is in cdt, but the compilation unit is in cdt-llvm...happy to have a quick chat and discuss?
Collaborator
Author
There was a problem hiding this comment.
@heifner Added test @ tools/toolchain-tester/examples/abigen-pass/abigen_test_enum_example.cpp.
Should be good to go now
heifner
approved these changes
Oct 30, 2025
…nk creation.
## ADDED `ENUM` SUPPORT: `abigen` support via `typedef` for `enum` (NOT `enum class`)
Generated ABI with the inclusion of `enum` types.
```json
{
...,
"version": "sysio::abi/1.2",
"types": [
{
"new_type_name": "chain_kind",
"type": "uint8"
}
],
...
}
```
## ++ Eliminated unnecessary `make_directory` and `create_symlink` calls from CMake macros, streamlining the installation process. Added support for handling plain C++ enums in `abigen`, allowing typedefs to map enums to their underlying storage types.
…olchain-tester`. - Introduced abigen test example for enum support with corresponding ABI JSON. - Re-added required header `bluegrass/meta/preprocessor.hpp`.
jglanz
force-pushed
the
feature/WIRE-194-abigen-support-enum
branch
from
2f05ff6 to
1bdf904
Compare
jglanz
added a commit
to Wire-Network/wire-sysio
that referenced
this pull request
Nov 10, 2025
…validate enum support with [CDT PR #15](Wire-Network/wire-cdt#15)
jglanz
added a commit
to Wire-Network/wire-sysio
that referenced
this pull request
Nov 25, 2025
…validate enum support with [CDT PR #15](Wire-Network/wire-cdt#15)
jglanz
added a commit
to Wire-Network/wire-sysio
that referenced
this pull request
Nov 25, 2025
…validate enum support with [CDT PR #15](Wire-Network/wire-cdt#15)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
API Changes
Documentation Additions