Skip to content

Conversation

@yeonjin719
Copy link
Member

🚨 관련 이슈

✨ 변경사항

  • 🐞 BugFix Something isn't working
  • 💻 CrossBrowsing Browser compatibility
  • 🌏 Deploy Deploy
  • 🎨 Design Markup & styling
  • 📃 Docs Documentation writing and editing (README.md, etc.)
  • ✨ Feature Feature
  • 🔨 Refactor Code refactoring
  • ⚙️ Setting Development environment setup
  • ✅ Test Test related (storybook, jest, etc.)

✏️ 작업 내용

  • 작업 내용

😅 미완성 작업

  • Task1

📢 논의 사항 및 참고 사항

@coderabbitai
Copy link

coderabbitai bot commented Aug 16, 2025

Caution

Review failed

The pull request is closed.

Summary by CodeRabbit

  • New Features
    • 단일 선택 필터에서 선택 항목을 다시 클릭하면 해제 가능(필터 값 null 처리).
    • 코스 페이지와 검색 페이지에 “필터 초기화” 컨트롤 추가; 헤더 액션을 “필터 초기화”와 “검색 필터”로 분리.
  • Bug Fixes
    • 초기 페이지 번호를 1로 시작하여 첫 렌더링 시 잘못된 페이지 진입을 방지.

Walkthrough

단일 선택형 필터 옵션에 토글 동작을 추가하고, 필터 초기화(reset) 기능을 UI에 연결했습니다. 페이지네이션 초기 값(current)을 1로 수정했습니다. 타입 정의에서 onChange가 null을 허용하도록 변경했습니다. useFilterStore가 reset을 추가로 반환하도록 사용처를 업데이트했습니다.

Changes

Cohort / File(s) Change Summary
단일 선택 토글 추가
src/components/dateCourse/dateCourseSearchFilterOption.tsx
choice 타입에서 isSelected 계산 도입, onClick이 onChange(isSelected ? null : apiValue)로 토글 동작 수행. 주석 추가. 다른 분기(choices/search/keyword/time) 무변경.
필터 초기화 UI 및 페이지네이션 초기값
src/pages/dateCourse/CoursePage.tsx, src/pages/dateCourse/FindDateCourse.tsx
useFilterStore에서 reset 추출 후 “필터 초기화” 버튼 추가(클릭 시 reset()). FindDateCourse의 current 초기값을 0→1로 변경. 헤더 액션을 “필터 초기화”와 “검색 필터”로 분리.
타입 업데이트
src/types/dateCourse/dateCourse.ts
TDateCourseSearchFilterOption의 onChange 시그니처를 (string

Sequence Diagram(s)

sequenceDiagram
  participant U as User
  participant C as DateCourseOptionButton
  participant S as FilterStore

  U->>C: 클릭(choice 옵션)
  C->>C: isSelected = (value === apiValue)
  alt 이미 선택됨
    C->>S: onChange(null)
  else 미선택
    C->>S: onChange(apiValue)
  end
Loading
sequenceDiagram
  participant U as User
  participant P as Course/FindDateCourse Page
  participant S as FilterStore

  U->>P: "필터 초기화" 클릭
  P->>S: reset()
  S-->>P: 필터 상태 초기화됨
  P->>P: 페이지 상태/리스트 재조회 트리거(기존 로직 유지)
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • [Deploy] 배포 #121: FindDateCourse의 페이지네이션 인덱싱 변경과 연동되어 초기 current 보정(1로 설정)과 직접적으로 관련됨.
  • [Deploy] 배포 #117: 데이트 코스 페이지의 페이지네이션/초기화 로직을 다루는 변경과 겹치는 부분이 있어 관련 가능성이 높음.

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between ca9e042 and 0606f0e.

📒 Files selected for processing (4)
  • src/components/dateCourse/dateCourseSearchFilterOption.tsx (1 hunks)
  • src/pages/dateCourse/CoursePage.tsx (2 hunks)
  • src/pages/dateCourse/FindDateCourse.tsx (2 hunks)
  • src/types/dateCourse/dateCourse.ts (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@yeonjin719 yeonjin719 merged commit 5e9029e into main Aug 16, 2025
2 of 3 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Aug 17, 2025
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants