This repository was archived by the owner on Dec 23, 2024. It is now read-only.
An unfinished mod selector #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please, fix my ugly formatting.
…nerate the description which will be displayed when you hover over the entry in the dropdown. Info may be auto-generate out of a Mod Entry or set manually.
… on value changed redraws the setting screen to display settings of the chosen mod.
…eturning false. I intended to add a toggle setting allowing to disable the mod at run-time (there's a field in mod info for that), but then realized it won't be possible to properly enable it back after reloading.
…any new VM and expect it to work correctly with the default dropdown.
ATTENTION - Build() function gotthe signature changed, it now returns generated mod info among other things
…o auto-generate ModInfo in TestSettings
In particualar, concatenate test settings and extra settings into a single mod entry thhrough AddAnotherGroup
…e mod name to the dropdown. Moved the call to redraw the screen from the setting itself to the UISetting. Deleted a duplicated call to add a ModEntry to the list of entries. Added a bunch of summaries
- Unify publicize task - Remove imports
Owner
|
Pushed some fixes and a bunch of cleanup. A few general notes:
|
…oid any possible NRE when accessing CurrentPack during when calling CreateString. strings will be registered later anyway when the first pack is loaded. Added another check for a <null>-returned value from Localized string in the Register method (just in case). And just generally formatted it more to my liking. Sorry :(
…ivate, because it is meant to be used only internally for creation of the static instance.
…Views for the sake of backward compatibility (their place now is taken by former Collapsible Subheaders). Also made a couple of Default Button transpilers prettier.
…hat the description view not show <null>). Also moved the creation of the instance inside the actual static constructor to make it prettier. (Is it?)
…uffer after a new settings group has been declared.
…ng only the first settings group passed to the constructor was actually stored.
… overloads and added several overloads of ModMenu.AddSettings in their stead. Extracted ModInfo structure from inside ModsMenuEntry. Added Chinese, German and French localization. Changed the construction of static UISettingsEntityDropdownModMenuEntry instance into unity's ScriptableObject CreateInstance to remove the warning in the log.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.