chore: separate the code in three different crates #206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Separate to the `prover`, `common`, `verifier` and `cli`. Rationale is that we'd like to be able to run the verifier without randomness, say on onchain targets (Solana SBF, WASM-based chains, etc.). Use the `custom` feature for getrandom in order to silence the linker when building for targets without support as the verifier doesn't need randomness anyway. Add an `onchain` Cargo profile that can be used to compile such targets. Also support cases in NTT where usize::BITS is not 64 for 2 adicity (e.g. WASM). To test some of these targets, go to the verifier dir and: ``` CARGO_PROFILE_RELEASE_LTO=fat \ CARGO_PROFILE_RELEASE_DEBUG=false \ CARGO_PROFILE_RELEASE_STRIP=symbols \ CARGO_PROFILE_RELEASE_CODEGEN_UNITS=1 cargo build-sbf ``` or ``` cargo build --target wasm32-unknown-unknown ``` Co-authored-by: Tsvetomir Dimitrov <tsv.dimitrov@gmail.com>
They remove static variable such that their names don't take space in the ELF symbol table. `disable-hash-counter`: disables the `HashCounter` static cached counter `disable-ntt-cache`: disables the static `NttEngine` engine cache Also, make the `parallel` feature optional in the `common` crate and the `spongefish` dependencies and use `parallel` in the `prover` crate only.
This allows for more efficient use by avoiding cloning inside the verifier that would happen every time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate to the
prover,common,verifierandcli.Rationale is that we'd like to be able to run the verifier without randomness, say on onchain targets (Solana SBF, WASM-based chains, etc.). Use the
customfeature for getrandom in order to silence the linker when building for targets without support as the verifier doesn't need randomness anyway.Add an
onchainCargo profile that can be used to compile such targets.Also support cases in NTT where usize::BITS is not 64 for 2 adicity (e.g. WASM).
To test some of these targets, go to the verifier dir and:
or