Update #199
Update #199
Conversation
wwjhu
commented
Nov 4, 2025
wwjhu
commented
- Update some of the dependencies, removes eslint-plugin-prettier which slows down linting.
- Update GitHub actions to be able to publish to GitHub Packages
…publishing packages
The main issue: It runs Prettier as an ESLint rule, which means: Significantly slower linting (Prettier wasn't designed to run this way) Prettier formatting issues show up as ESLint errors, cluttering your error output with style violations alongside actual code problems Confusing experience when ESLint reports hundreds of "errors" that are just formatting Better approach: Run Prettier and ESLint separately: Use eslint-config-prettier (note: config, not plugin) - this disables ESLint rules that conflict with Prettier Run Prettier independently (via editor integration, pre-commit hooks, or separate npm scripts) Let ESLint focus on code quality issues, Prettier handle formatting
…PM security updates)
jaapvanblaaderen
left a comment
jaapvanblaaderen
left a comment
There was a problem hiding this comment.
I have some small remarks. Maybe it's also nice to have a few words in the readme on how the OIDC auth is configured (link to: https://docs.npmjs.com/trusted-publishers)?
| - name: publish npm stable | ||
| uses: epeli/npm-release@v1 | ||
| with: | ||
| type: stable | ||
| token: ${{ secrets.NPM_TOKEN }} |
There was a problem hiding this comment.
I guess specifying the token here should not be needed anymore as this is now covered by the OIDC auth? Also wondering what this action brings instead of just executing npm publish
There was a problem hiding this comment.
True, but it seems epeli/npm-release requires the token to be set. Not sure if we can continue using that action.
That makes sense, will add something |
