Skip to content

Comments

Clarify Types for Autocomplete#185

Merged
cdartnell-wgs merged 10 commits intomasterfrom
dev/autocomplete_pois
Nov 3, 2025
Merged

Clarify Types for Autocomplete#185
cdartnell-wgs merged 10 commits intomasterfrom
dev/autocomplete_pois

Conversation

@gaelsimon
Copy link
Member

@gaelsimon gaelsimon commented Oct 27, 2025

Issue

related to Woosmap/localities#1362

Describe your changes

autocomplete now accepts all poi categories as valid types parameters, and returns them in the response.
Woosmap/localities#1379 will adapt geocode to act the same.

This pr adapts the ref doc in an attempt to clarify the different type families we use.

How to test

check the preview

Checklist:

  • My code follows the style guidelines for this repo
  • My code passes the SonarCloud check and does not add new code smells
  • I have performed a self-review of my code
  • My changes generate no new warnings/errors
  • I have added tests that prove my fix is effective or that my feature works
  • I don't require ops changes for this PR to go to prod
  • This change does not include a migration

Documentation

Libs/SDKs

@cdartnell-wgs
Copy link
Contributor

/update-dist

@cdartnell-wgs
Copy link
Contributor

/update-dist

@cdartnell-wgs
Copy link
Contributor

/update-dist

@cdartnell-wgs cdartnell-wgs added the PO Review This issues is ready for PO Review label Oct 28, 2025
@cdartnell-wgs cdartnell-wgs marked this pull request as ready for review October 28, 2025 17:31
@lpernelle-woosmap
Copy link
Contributor

This information is not easy to find:
image

But it's not a blocker, functional review ✅

@cdartnell-wgs cdartnell-wgs merged commit fbbe6ee into master Nov 3, 2025
@cdartnell-wgs cdartnell-wgs deleted the dev/autocomplete_pois branch November 3, 2025 14:17
@lpernelle-woosmap lpernelle-woosmap removed the PO Review This issues is ready for PO Review label Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants