-
Notifications
You must be signed in to change notification settings - Fork 43
57 review and streamline contributor and developer documentation #169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
57 review and streamline contributor and developer documentation #169
Conversation
…md`, `EXPERIMENTS_DEVELOPER_GUIDE.md`, and `RELEASE_INSTRUCTIONS.md`. Updated `CONTRIBUTING.md` to include revised setup and coding standards.
…EW.md` and add REST API testing documentation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @pbearne@git.wordpress.org, @hrishikesh2810. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #169 +/- ##
==========================================
Coverage 47.97% 47.97%
Complexity 243 243
==========================================
Files 22 22
Lines 1430 1430
==========================================
Hits 686 686
Misses 744 744
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@pbearne would be great to get your GitHub and WPORG accounts linked (see bot message above) as that makes crediting back to WPORG accounts more automated/reliable. |
| composer install && npm i && npm run build | ||
| ``` | ||
|
|
||
| > **Note:** The `wordpress/wp-ai-client` package will be added to `composer.json` once it's officially released. For now, the plugin scaffolding is ready for integration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is outdated information. This package is now included in our composer config
| ``` | ||
| ### Quality checks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to have a line break between these
| * `develop`: The main development branch. | ||
| * `trunk`: The stable release branch. | ||
| * `release/*`: A branch for a specific release, useful e.g. for applying a hotfix. | ||
| * `feature/*`: A branch for a larger feature that takes multiple iterative PRs towards completion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We haven't been following this so I'd suggest we remove it
|
|
||
| These special branches are protected and are configured more strictly in regards to GitHub workflow configuration. | ||
|
|
||
| Branches that you use for implementing a pull request or experimenting can use any naming convention you prefer, _except_ the above. Additionally, please do not use branch names that would easily cause confusion, such as other common main branch names like `main` or `develop`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've already mentioned develop above so no need to repeat that here
| │ └── Example_Experiment/ # Each experiment in own directory | ||
| │ ├── Example_Experiment.php | ||
| │ └── README.md | ||
| ├── admin/ # Admin interface (planned) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This directory doesn't exist so should be removed from here
| │ ├── Example_Experiment.php | ||
| │ └── README.md | ||
| ├── admin/ # Admin interface (planned) | ||
| ├── assets/ # CSS, JS, images |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also doesn't exist
| │ ├── RELEASE_INSTRUCTIONS.md # Release Instructions | ||
| │ ├── TESTING.md # Testing strategy | ||
| │ └── TESTING_REST_API.md # Testing API strategy | ||
| ├── languages/ # Translation files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't exist
| ai/ | ||
| ├── ai.php # Plugin bootstrap | ||
| ├── build/ # Built assets | ||
| ├── includes/ # Core plugin code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing the Abilities and Settings directories
Co-authored-by: Darin Kotter <darin.kotter@gmail.com>
Co-authored-by: Darin Kotter <darin.kotter@gmail.com>
Co-authored-by: Darin Kotter <darin.kotter@gmail.com>
Co-authored-by: Darin Kotter <darin.kotter@gmail.com>
Co-authored-by: Darin Kotter <darin.kotter@gmail.com>
|
@pbearne I've applied most of the recommended changes here, would you mind handling the rest called out above? |
What?
Closes #57
Why?