chore: Merge prerelease/minor into prerelease/major #3687
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolve issue with incorrect calculations in non-chrome browsers. getBoundingClientRect take into account: width + padding + border + scroll clientWidth: - In firefox does not take padding into account - Does not take border into account (that why there was +2 hack previously I assume) It should not lead to any notable visual by most of users in Chrome. Popup will match size of the input (+2px for the border). In other browsers behavior will match. Since border-box used for all sizing using getBoundingClientRect looks like a correct approach for coherent sizing across browsers and devices. Samples: Before: Firefox: <img width="531" height="640" alt="image" src="https://github.com/user-attachments/assets/d606358e-acf5-43b2-88f3-f49e9a7b02a4" /> Edge: <img width="499" height="573" alt="image" src="https://github.com/user-attachments/assets/52df9a71-3169-4f90-bbbb-ee5cd203876a" /> After: Firefox: <img width="559" height="602" alt="image" src="https://github.com/user-attachments/assets/69c06115-cc69-4e0f-9749-971ad04278a4" /> Edge: <img width="529" height="719" alt="image" src="https://github.com/user-attachments/assets/cc05b233-7bec-41e2-bb6a-b2c443698336" /> [category:SelectMenu ComboBox (and derived ones)]
It's useful information when a component has `variant="inverse"` adding this to insights tracking. [category:Components] Co-authored-by: manuel.carrera <manuel.carrera@workday.com> Co-authored-by: Alan Smith <a.smith@workday.com>
Fixes: #3682 Adds a new `.mdc` (Markdown with Cursor rules) file to provide Canvas Kit best practices for developers using AI assistants like Cursor and Claude. This file helps teams ensure consistent adherence to Canvas Kit patterns by providing: - Token usage guidelines (system tokens, import patterns) - Styling best practices (`createStyles`, `createStencil`, `cs` prop) - Component patterns (compound components, controlled components) - Accessibility guidelines (semantic HTML, ARIA, keyboard navigation) - Theming guidelines (global vs scoped theming) - Code style conventions The content is derived from existing Canvas Kit documentation in `modules/docs/` and synthesized into a single, always-applied rule file. [category:Documentation] Release Note: Added `modules/docs/llm/canvas-kit.mdc` - a Cursor/Claude rules file containing Canvas Kit best practices. Teams can add this to their `.cursor/rules/` directory to have AI assistants follow Canvas Kit conventions automatically. Co-authored-by: Youry Stancatte <youry.stancatte@at3wn6qqt2g.workdayinternal.com>
…nButton (#3691) Fixes: #3690 Fixes the default color for icon buttons and toolbar dropdown buttons. Currently, the buttons are the same color as disabled buttons, making it difficult to differentiate when a button is disabled or not. [category:Components] Co-authored-by: Adam Bui <adam.bui@workday.com>
mannycarrera4
approved these changes
Jan 16, 2026
Workday/canvas-kit
|
||||||||||||||||||||||||||||||||||||||||
| Project |
Workday/canvas-kit
|
| Branch Review |
merge/prerelease/minor-into-prerelease/major
|
| Run status |
|
| Run duration | 02m 16s |
| Commit |
|
| Committer | Alan B Smith |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
15
|
Skipped
|
0
|
Passing
|
802
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
19.47%
|
|
|---|---|
|
Untested elements
|
1520
|
|
Tested elements
|
365
|
Accessibility
99.47%
|
|
|---|---|
|
Failed rules
|
5 critical
5 serious
0 moderate
2 minor
|
|
Failed elements
|
71
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request was automatically created by an automated forward-merge job. The automated job failed automated checks and must be resolved manually.
Reasons for failure may include:
The pull request should inform you of merge conflicts before you start if any.
If there were no merge conflicts, the forward-merge job failed because of a test failure. You can wait for the pull request to give errors, or you can check the logs for failures. You'll have to update code to fix errors.
This pull request will be merged using the
mergestrategy instead of thesquashstrategy. This means any commit in the log will show in the branch's history. Any commit you make should amend the merge commit. Use the following command:You must then force-push the branch and the CI will rerun verification.
Use the
automergelabel like normal and the CI will pick the correct merge strategy.