feat: add WAMR dependency #5790
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5790 +/- ##
=========================================
- Coverage 78.2% 78.2% -0.0%
=========================================
Files 816 816
Lines 68948 68948
Branches 8352 8354 +2
=========================================
- Hits 53950 53941 -9
- Misses 14998 15007 +9 see 5 files with indirect coverage changes 🚀 New features to boost your workflow:
|
BUILD.md
Outdated
| git sparse-checkout add recipes/soci | ||
| git fetch origin master | ||
| git checkout master | ||
| conan export --version 2.4.1 external/wamr # TODO: needs to be added to the conan center index |
There was a problem hiding this comment.
We've just removed all conan packaging code from external, let's not add it back please.
Could you please create this PR in http://github.com/XRPLF/conan-center-index?
It's our fork of official CCI, so we will be reviewing code, not Conan team
There was a problem hiding this comment.
XRPLF/conan-center-index#17, please add it to conan
Tapanito
added
the
Triaged
|
This separate PR is no longer needed because we added the dependency to our CCI fork (and Artifactory). If you really need it, this PR should be refactored to use the new package we added. |
mathbunnyru
left a comment
mathbunnyru
left a comment
There was a problem hiding this comment.
Overall, LGTM, left some nitpicking comments
vvysokikh1
left a comment
vvysokikh1
left a comment
There was a problem hiding this comment.
lgtm, but I'll leave the approval to @mathbunnyru
Already left my review, so waiting for these small things to be fixed |
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com>
| xrpl.libpb | ||
| xxHash::xxhash | ||
| $<$<BOOL:${voidstar}>:antithesis-sdk-cpp> | ||
| ) | ||
|
|
||
| if (WIN32) | ||
| target_link_libraries(xrpl.imports.main INTERFACE ntdll) |
There was a problem hiding this comment.
I don't know if this is related, so leaving this change to rippled team
|
Closed in favor of #5999 |
High Level Overview of Change
This PR adds WAMR as a dependency to rippled, in preparation for Smart Escrows.
Context of Change
Splitting up #5600 into more managably reviewable chunks
XLS-102
Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
N/A
Test Plan
CI passes and everything compiles in properly without error.
Future Tasks
Additional PRs for the rest of the Smart Escrow functionality