fix start function infinite loop bug

[pwang200]

High Level Overview of Change

Context of Change

Type of Change

• [ x] Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Refactor (non-breaking change that only restructures code)
• Performance (increase or change in throughput and/or latency)
• Tests (you added tests for code that already exists, or your new feature included in this PR)
• Documentation update
• Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
• Release

API Impact

• Public API: New feature (new methods and/or new fields)
• Public API: Breaking change (in general, breaking changes should only impact the next api_version)
• libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
• Peer protocol change (must be backward compatible or bump the peer protocol version)

[codecov]

Codecov Report

❌ Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 79.6%. Comparing base (9ed60b4) to head (82c7c7d).
⚠️ Report is 1 commits behind head on ripple/wasmi-host-functions.

Files with missing lines	Patch %	Lines
src/xrpld/app/wasm/detail/WasmiVM.cpp	93.3%	1 Missing ⚠️

Additional details and impacted files

@@                     Coverage Diff                     @@
##           ripple/wasmi-host-functions   #6172   +/-   ##
===========================================================
  Coverage                         79.6%   79.6%           
===========================================================
  Files                              845     845           
  Lines                            73319   73329   +10     
  Branches                          8363    8353   -10     
===========================================================
+ Hits                             58367   58392   +25     
+ Misses                           14952   14937   -15     

Files with missing lines	Coverage Δ
src/xrpld/app/wasm/WasmiVM.h	93.9% <ø> (ø)
src/xrpld/app/wasm/detail/WasmiVM.cpp	95.5% <93.3%> (+2.3%)	⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[mvadari]

Do we need this and #6064? i.e. should that PR be closed?

[oleks-rip]

this already fixed, you need to rebase

[pwang200]

I think it is rebased already. This line is to make sure the imports are built (hence tested), even when the module instance is not instantiated. I am not sure what previous fix relates to this change.

[pwang200]

@mvadari we still need this since it tests infinite loop in the start function that runs automatically right after module instantiation without explicitly calling the start.