Skip to content

Conversation

@mvadari
Copy link
Collaborator

@mvadari mvadari commented Jan 14, 2026

High Level Overview of Change

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@mvadari mvadari added the DraftRunCI Normally CI does not run on draft PRs. This opts in. label Jan 14, 2026
@codecov
Copy link

codecov bot commented Jan 22, 2026

Codecov Report

❌ Patch coverage is 12.50000% with 63 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.8%. Comparing base (977caea) to head (3260541).

Files with missing lines Patch % Lines
src/xrpld/app/wasm/host_functions.macro 0.0% 62 Missing ⚠️
...xrpld/app/wasm/detail/HostFuncImplLedgerHeader.cpp 85.7% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                      Coverage Diff                      @@
##           ripple/wasmi-host-functions   #6218     +/-   ##
=============================================================
- Coverage                         79.9%   79.8%   -0.1%     
=============================================================
  Files                              854     855      +1     
  Lines                            73782   73841     +59     
  Branches                          8301    8360     +59     
=============================================================
+ Hits                             58918   58922      +4     
- Misses                           14864   14919     +55     
Files with missing lines Coverage Δ
src/xrpld/app/wasm/HostFunc.h 100.0% <ø> (ø)
src/xrpld/app/wasm/HostFuncImpl.h 84.6% <ø> (ø)
src/xrpld/app/wasm/detail/HostFuncImplFloat.cpp 99.1% <100.0%> (ø)
src/xrpld/app/wasm/detail/HostFuncWrapper.cpp 93.8% <100.0%> (-<0.1%) ⬇️
...xrpld/app/wasm/detail/HostFuncImplLedgerHeader.cpp 96.2% <85.7%> (-3.8%) ⬇️
src/xrpld/app/wasm/host_functions.macro 0.0% <0.0%> (ø)

... and 1 file with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DraftRunCI Normally CI does not run on draft PRs. This opts in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant