Skip to content

Add canonical "scale" computation to Number #6246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ximinez wants to merge 14 commits into
base: tapanito/lending-vault-invariant
Choose a base branch
from
Open

Add canonical "scale" computation to Number #6246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
7ab9709
Add canonical "scale" computation to Number
ximinez Jan 21, 2026
e5646e4
Merge remote-tracking branch 'XRPLF/tapanito/lending-vault-invariant'…
ximinez Jan 21, 2026
040bf34
ValidVault tracks scale of original operands alongside deltas
ximinez Jan 21, 2026
2f0690f
Merge remote-tracking branch 'XRPLF/tapanito/lending-vault-invariant'…
ximinez Jan 21, 2026
cd4f915
Update src/xrpld/app/tx/detail/InvariantCheck.cpp
ximinez Jan 22, 2026
accbe73
Change ValidVault::DeltaInfo::scale to an optional
ximinez Jan 23, 2026
47bfd15
Merge branch 'tapanito/lending-vault-invariant' into ximinez/number-s…
ximinez Jan 28, 2026
5f8acbc
Use 2^63-1 as maxMantissa for large range
ximinez Jan 23, 2026
e7f81c2
Remove the _ suffixes from doNormalize function parameters
ximinez Jan 26, 2026
a48182c
Convert "bool negative_ & uint64_t mantissa_" combo back to "rep mant…
ximinez Jan 27, 2026
7e2c257
Fix bugs
ximinez Jan 27, 2026
f0eef6e
Reduce expensive(?) accesses to thread_local MantissaRange
ximinez Jan 27, 2026
0364d61
Clean-ups and tweaks
ximinez Jan 28, 2026
7c499aa
Add unit tests for normalizeToRange
ximinez Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
354 changes: 273 additions & 81 deletions include/xrpl/basics/Number.h
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion include/xrpl/protocol/Protocol.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ std::size_t constexpr maxMPTokenMetadataLength = 1024;

/** The maximum amount of MPTokenIssuance */
std::uint64_t constexpr maxMPTokenAmount = 0x7FFF'FFFF'FFFF'FFFFull;
static_assert(Number::maxRep >= maxMPTokenAmount);
static_assert(Number::largestMantissa >= maxMPTokenAmount);

/** The maximum length of Data payload */
std::size_t constexpr maxDataPayloadLength = 256;
Expand Down
4 changes: 4 additions & 0 deletions include/xrpl/protocol/STAmount.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -568,6 +568,10 @@ STAmount::fromNumber(A const& a, Number const& number)
return STAmount{asset, intValue, 0, negative};
}

XRPL_ASSERT_PARTS(
working.signum() >= 0,
"ripple::STAmount::fromNumber",
"non-negative Number to normalize");
auto const [mantissa, exponent] =
working.normalizeToRange(cMinValue, cMaxValue);

Expand Down
2 changes: 1 addition & 1 deletion include/xrpl/protocol/SystemParameters.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ systemName()
/** Number of drops in the genesis account. */
constexpr XRPAmount INITIAL_XRP{100'000'000'000 * DROPS_PER_XRP};
static_assert(INITIAL_XRP.drops() == 100'000'000'000'000'000);
static_assert(Number::maxRep >= INITIAL_XRP.drops());
static_assert(Number::largestMantissa >= INITIAL_XRP.drops());

/** Returns true if the amount does not exceed the initial XRP in existence. */
inline bool
Expand Down
Loading
Loading