Add more Auditor Tests #6255

PeterChen13579 · 2026-01-21T22:52:12Z

High Level Overview of Change

Adds more unit tests for Auditor feature in Confidential Transfer

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Refactor (non-breaking change that only restructures code)
Performance (increase or change in throughput and/or latency)
Tests (you added tests for code that already exists, or your new feature included in this PR)
Documentation update
Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
Release

API Impact

Public API: New feature (new methods and/or new fields)
Public API: Breaking change (in general, breaking changes should only impact the next api_version)
libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
Peer protocol change (must be backward compatible or bump the peer protocol version)

codecov · 2026-01-21T23:14:42Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.0%. Comparing base (67e8e89) to head (c38a3b3).
⚠️ Report is 15 commits behind head on ripple/confidential-transfer.

Additional details and impacted files

@@                      Coverage Diff                       @@
##           ripple/confidential-transfer   #6255     +/-   ##
==============================================================
- Coverage                          79.1%   79.0%   -0.1%     
==============================================================
  Files                               850     850             
  Lines                             72015   72594    +579     
  Branches                           8385    8416     +31     
==============================================================
+ Hits                              56975   57340    +365     
- Misses                            15040   15254    +214

Files with missing lines	Coverage Δ
...rc/xrpld/app/tx/detail/ConfidentialConvertBack.cpp	`91.5% <100.0%> (-1.7%)`	⬇️

... and 9 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

shawnxie999 · 2026-01-23T17:25:25Z

could the conflict be resolved? thanks

yinyiqian1 · 2026-01-23T21:41:08Z

src/test/app/ConfidentialTransfer_test.cpp

         0xAD, 0x0B, 0xE3, 0x91, 0x50, 0xDA, 0x2F, 0x75, 0xC6, 0xBD, 0x42};

+    // a valid hardcoded ciphertext for testing
+    constexpr static unsigned char


I have a refactor in #6274
So we can get rid of this and call the getTrivialCiphertext() after that PR is merged

yinyiqian1 · 2026-01-23T22:03:01Z

src/test/app/ConfidentialTransfer_test.cpp

+                 .amt = 10,
+                 .holderPubKey = mptAlice.getPubKey(bob),
+                 .auditorEncryptedAmt =
+                     Buffer{badCiphertext, ecGamalEncryptedTotalLength},


https://github.com/XRPLF/rippled/pull/6274/files modified to use getBadCiphertext().
You can update it after https://github.com/XRPLF/rippled/pull/6274/files is merged

yinyiqian1 · 2026-01-23T22:13:27Z

src/test/app/ConfidentialTransfer_test.cpp

+
+            mptAlice.generateKeyPair(alice);
+
+            mptAlice.set(


auditor key is invalid length, pub key is invalid have similar setup. We can just move the code of line 436 after 399.

yinyiqian1 · 2026-01-23T22:13:59Z

src/test/app/ConfidentialTransfer_test.cpp

+            mptAlice.generateKeyPair(alice);
+
+            // Providing only auditor key should fail
+            mptAlice.set(


same here, we can move after line 399. The setup lines can be shared

yinyiqian1 · 2026-01-23T22:14:53Z

src/test/app/ConfidentialTransfer_test.cpp

+                {.account = alice,
+                 .auditorPubKey = mptAlice.getPubKey(alice),
+                 .err = temMALFORMED});
+        }


We should also test:

if (hasHolder && (hasIssuerElGamalKey || hasAuditorElGamalKey)) return temMALFORMED;

and this can also be added after line 399

yinyiqian1 · 2026-01-23T22:27:33Z

src/test/app/ConfidentialTransfer_test.cpp

+                 .auditorPubKey = mptAlice.getPubKey(auditor)});
+
+            // no auditor encrypted amt provided
+            mptAlice.convert(


In the test framework, even if the auditor's encrypted amt is not provided, it will fill in the auditor's encrypted amount automatically: https://github.com/XRPLF/rippled/blob/ripple/confidential-transfer/src/test/jtx/impl/mpt.cpp#L1015C5-L1015C30

Could you double check if this is failing at the expected line? I think we need some logic in test framework to force it not auto filling this field.

yinyiqian1 · 2026-01-23T22:29:59Z

src/test/app/ConfidentialTransfer_test.cpp

+        // We set the auditor key, but auditorEncryptedAmt is missing
+        // Note：we need to create a new MPTTester to reset the state
+        {
+            Env env2{*this, features};


the naming should remove 2

shawnxie999 · 2026-01-26T19:13:32Z

src/test/jtx/impl/mpt.cpp

    std::optional<Buffer>& auditorCiphertext,
-    Buffer& blindingFactor) const
+    Buffer& blindingFactor,
+    bool fillAuditorEncryptedAmt) const


why is this fillAuditorEncryptedAmt param needed? which test would fail otherwise?

It fails the test where we want to test for if (requiresAuditor != hasAuditor)
Essentially, fillConversionCiphertexts makes sure if the field auditor is present, it fills the auditorEncryptedAmt, so I created a bool field to prevent this

shawnxie999 · 2026-01-26T19:16:43Z

src/test/app/ConfidentialTransfer_test.cpp

        }

+        // cannot convert if auditor key is set, but auditor amount is not
+        // provided


should also test MPTokenIssuanceSet where the issuer has already set IssuerPublicKey. Then they try to set AuditorPublicKey, which should fail.

PeterChen13579 requested review from shawnxie999 and yinyiqian1 January 22, 2026 16:56

yinyiqian1 requested changes Jan 23, 2026

View reviewed changes

shawnxie999 reviewed Jan 26, 2026

View reviewed changes

PeterChen13579 requested a review from a team as a code owner January 27, 2026 18:32

PeterChen13579 force-pushed the ripple/confidential-transfer branch from 13672c5 to c38a3b3 Compare January 27, 2026 18:34

PeterChen13579 added 2 commits January 27, 2026 13:40

add more auditor tests

99e66c9

fix a couple comments

3a86ae6

PeterChen13579 force-pushed the ripple/confidential-transfer branch from c38a3b3 to 3a86ae6 Compare January 27, 2026 18:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add more Auditor Tests #6255

Add more Auditor Tests #6255

PeterChen13579 commented Jan 21, 2026

Uh oh!

codecov bot commented Jan 21, 2026 •

edited

Loading

Uh oh!

shawnxie999 commented Jan 23, 2026

Uh oh!

yinyiqian1 Jan 23, 2026 •

edited

Loading

Uh oh!

yinyiqian1 Jan 23, 2026

Uh oh!

yinyiqian1 Jan 23, 2026

Uh oh!

yinyiqian1 Jan 23, 2026 •

edited

Loading

Uh oh!

yinyiqian1 Jan 23, 2026

Uh oh!

yinyiqian1 Jan 23, 2026

Uh oh!

yinyiqian1 Jan 23, 2026

Uh oh!

shawnxie999 Jan 26, 2026

Uh oh!

PeterChen13579 Jan 27, 2026

Uh oh!

shawnxie999 Jan 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Add more Auditor Tests #6255

Are you sure you want to change the base?

Add more Auditor Tests #6255

Conversation

PeterChen13579 commented Jan 21, 2026

High Level Overview of Change

Type of Change

API Impact

Uh oh!

codecov bot commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

shawnxie999 commented Jan 23, 2026

Uh oh!

yinyiqian1 Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yinyiqian1 Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov bot commented Jan 21, 2026 •

edited

Loading

yinyiqian1 Jan 23, 2026 •

edited

Loading

yinyiqian1 Jan 23, 2026 •

edited

Loading