Reject non-canonical binaries #6277
Conversation
oleks-rip
changed the base branch from
develop
to
ripple/wasmi-host-functions
src/test/app/HostFuncImpl_test.cpp
Outdated
| } | ||
|
|
||
| void | ||
| testFloatNonCanonical() |
There was a problem hiding this comment.
Can we combine testFloatNonIOU and testFloatNonCanonical into something like testFloatSpecialCases?
src/test/app/HostFuncImpl_test.cpp
Outdated
| void | ||
| testFloatNonCanonical() | ||
| { | ||
| testcase("float Xrp+Mpt"); |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## ripple/wasmi-host-functions #6277 +/- ##
===========================================================
Coverage 79.9% 79.9%
===========================================================
Files 854 854
Lines 73782 73799 +17
Branches 8301 8301
===========================================================
+ Hits 58918 58935 +17
Misses 14864 14864
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
oleks-rip
force-pushed
the
float_canon
branch
from
e78687d to
89654d2
Compare
| std::string | ||
| floatToString(Slice const& data) | ||
| { | ||
| detail::FloatState rm(0); |
There was a problem hiding this comment.
Floats has global state for rounding and mantissa length. FloatState restore that state on return / exception
There was a problem hiding this comment.
If it's restored, why does it need to be instantiated here?
There was a problem hiding this comment.
We save current state of the Numbers during initialization, switch to our state and restore state on exit, so every float host-functions doesn't change system settings for floats. Isn't it obvious?
There was a problem hiding this comment.
Discussed offline.
It's done in the other functions, the other functions just take a mode param to signify the rounding mode used in the math. These two functions don't need a rounding mode since there is no computation done, so we can just use the regular rounding mode.
| { | ||
| try | ||
| { | ||
| detail::FloatState rm(0); |
oleks-rip
merged commit c1c1b4e
into
XRPLF:ripple/wasmi-host-functions
2 participants
High Level Overview of Change
Check and reject slices if they are non-canonical (which is possible if craft binary manually) but still represent valid number.
Type of Change
.gitignore, formatting, dropping support for older tooling)