Skip to content

Conversation

@Tapanito
Copy link
Collaborator

High Level Overview of Change

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@Tapanito Tapanito added the DraftRunCI Normally CI does not run on draft PRs. This opts in. label Jan 27, 2026
@codecov
Copy link

codecov bot commented Jan 27, 2026

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 79.4%. Comparing base (69dda6b) to head (ecd8a94).

Files with missing lines Patch % Lines
src/xrpld/app/tx/detail/InvariantCheck.cpp 75.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##           release-3.1   #6282     +/-   ##
=============================================
- Coverage         79.4%   79.4%   -0.0%     
=============================================
  Files              839     839             
  Lines            71723   71712     -11     
  Branches          8257    8255      -2     
=============================================
- Hits             56921   56909     -12     
- Misses           14802   14803      +1     
Files with missing lines Coverage Δ
include/xrpl/protocol/detail/ledger_entries.macro 100.0% <ø> (ø)
include/xrpl/protocol/detail/transactions.macro 100.0% <ø> (ø)
src/xrpld/app/tx/detail/LoanBrokerSet.cpp 95.1% <100.0%> (-0.3%) ⬇️
src/xrpld/app/tx/detail/LoanManage.cpp 89.2% <ø> (-0.1%) ⬇️
src/xrpld/app/tx/detail/InvariantCheck.cpp 92.3% <75.0%> (ø)

... and 1 file with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DraftRunCI Normally CI does not run on draft PRs. This opts in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants