Skip to content

Conversation

@ximinez
Copy link
Collaborator

@ximinez ximinez commented Jan 29, 2026

High Level Overview of Change

Combines #6150 and #6275.

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

- That makes minMantissa 2^63/10+1.
- Simplifies many of the existing operations, and removes the need for
  the accessors (mantissa() & exponent()) to do any math.
- Simplify shiftExponent().
- Clean up to_string() to prevent integers from including "e0".
- Fix root() and root2() computations by ensuring the mantissas have
  a consistent length.
- Steal changes from @pratik's #6150 to avoid UB
@ximinez ximinez added the DraftRunCI Normally CI does not run on draft PRs. This opts in. label Jan 29, 2026
@codecov
Copy link

codecov bot commented Jan 29, 2026

Codecov Report

❌ Patch coverage is 97.88732% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.4%. Comparing base (6334be1) to head (ddbd78c).

Files with missing lines Patch % Lines
src/libxrpl/basics/Number.cpp 98.3% 2 Missing ⚠️
include/xrpl/basics/Number.h 95.5% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                         Coverage Diff                         @@
##           pratik/Fix_asan_lsan_flagged_issues   #6292   +/-   ##
===================================================================
  Coverage                                 79.4%   79.4%           
===================================================================
  Files                                      839     839           
  Lines                                    71629   71639   +10     
  Branches                                  8237    8235    -2     
===================================================================
+ Hits                                     56858   56868   +10     
  Misses                                   14771   14771           
Files with missing lines Coverage Δ
include/xrpl/protocol/Protocol.h 100.0% <ø> (ø)
include/xrpl/protocol/STAmount.h 96.0% <100.0%> (+<0.1%) ⬆️
include/xrpl/protocol/SystemParameters.h 100.0% <ø> (ø)
include/xrpl/protocol/detail/ledger_entries.macro 100.0% <ø> (ø)
include/xrpl/basics/Number.h 98.1% <95.5%> (-0.7%) ⬇️
src/libxrpl/basics/Number.cpp 98.4% <98.3%> (-0.4%) ⬇️

... and 2 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DraftRunCI Normally CI does not run on draft PRs. This opts in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants