-
Notifications
You must be signed in to change notification settings - Fork 80
implement linkat #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
implement linkat #80
Conversation
|
Nice, we've been meaning to add this for ages. Before I review, I'd change the main tests so that they take an option to create a file with tmpfile + link, and then run them with that option and check that things are fine. And I'd also just add a very basic test that checks if that works. |
mcrnic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have some bugs around dget_parent dput
Issues:
- you call
dget_parentin ternfs_link but it will not be put ifflush_and_linkerrors - you don't call
dget_parentinternfs_file_flushbut then you dodputinflush_and_linkif it does not errors
|
made it always dget/dput the parent |
|
ah i think i can scope it better |
this implements .tmpfile and .link
it also abstracts the common path of flushing and linking into a helper function