Skip to content

Conversation

@izabera
Copy link
Collaborator

@izabera izabera commented Dec 2, 2025

this implements .tmpfile and .link
it also abstracts the common path of flushing and linking into a helper function

@bitonic
Copy link
Collaborator

bitonic commented Dec 2, 2025

Nice, we've been meaning to add this for ages. Before I review, I'd change the main tests so that they take an option to create a file with tmpfile + link, and then run them with that option and check that things are fine. And I'd also just add a very basic test that checks if that works.

Copy link
Collaborator

@mcrnic mcrnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have some bugs around dget_parent dput

Issues:

  1. you call dget_parent in ternfs_link but it will not be put if flush_and_link errors
  2. you don't call dget_parent in ternfs_file_flush but then you do dput in flush_and_link if it does not errors

@izabera izabera requested a review from mcrnic December 2, 2025 10:31
@izabera
Copy link
Collaborator Author

izabera commented Dec 2, 2025

made it always dget/dput the parent

@izabera
Copy link
Collaborator Author

izabera commented Dec 2, 2025

ah i think i can scope it better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants