relaxed move idempotency requirements #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used to only check if the move operation happened if we retried. With multiple regions which can retry independently, detecting if we retried from client becomes unreliable. In this change we relax the idempotency check to succeed if the requrested operation succeeded and the creation time of the new edge is "close enough" to current time. Currently close enough is 1 minute. Previously if 2 clients tried to move the same file to the same target concurrently, one would succeed and the other would get edge not found. With this change, both may succeed if they are close enough in time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to only check if the move operation happened if we retried. With multiple regions which can retry independently, detecting if we retried from client becomes unreliable.
In this change we relax the idempotency check to succeed if the requrested operation succeeded and the creation time of the new edge is "close enough" to current time. Currently close enough is 1 minute.
Previously if 2 clients tried to move the same file to the same target concurrently, one would succeed and the other would get edge not found. With this change, both may succeed if they are close enough in time.