Open
Conversation
Contributor
|
This seems like a good enough reason to consider making them share a common base class so we can be more specific than |
Contributor
Author
|
Agreed. Just submitted: bluesky/databroker#583. We could also change the signal to Catalog instead of object, but it would be great for this (and I assume other places in Xi-CAM) to have a class that indicates that we have a run, whether Remote or local. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12
When you setup an intake-server as your source, you a run is note represented as a BlueskyRun, rather a RemoteBlueskyRun which is, surprisingly, not a BlueskyRun.