Implement guard against overrun in XEmacPs_BdRingFromHwRx. #222
+2,027,097
−156,314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch updates ClearStatus in Status only if Status is success. If Status was failure then original error code is returned. Signed-off-by: Harsha <harsha.harsha@xilinx.com> Acked-by: Vikram Sreenivasa Batchali <b.vikram@xilinx.com>
Updated IIC driver version with 3.9 and addtogroup version with Overview Signed-off-by: Manikanta Guntupalli <manikanta.guntupalli@xilinx.com> Acked-for-series: Srinivas Goud <srinivas.goud@xilinx.com>
While reading single byte, getting both RX FULL and TX error interrupts. RX FULL interrupt is to intimate byte received. TX error is due to NACK from master to slave to intimate communication completed. In Interrupt Service Routine we are handling only TX error and not handling RX FULL, when both interrupts occured. To fix this issue, handling RX FULL interrupt before TX error interrupt and clearing TX error interrupt while handling RX FULL interrupt when receive byte count is one, because here the TX error interrupt indicate NACK, not actually TX error. Signed-off-by: Manikanta Guntupalli <manikanta.guntupalli@xilinx.com> Acked-for-series: Srinivas Goud <srinivas.goud@xilinx.com>
Commit 0949b4f updating the already existing ipname variable due to which wrong instance name is getting generated in the testperiph.c, resulting compilation errors, This commit fixes this issue. Signed-off-by: Appana Durga Kedareswara rao <appana.durga.rao@xilinx.com> Acked-by: Siva Durga Prasad Paladugu<siva.durga.paladugu@xilinx.com>
…lure During subsystem creation, requirements are added for all the devices. However, this is unnecessary. There are a few types of devices which are never requested at runtime by any PM client - such as VDU, GTs, BFRB etc. We can optimize for these types of devices and skip adding requirements for them. On VC1902, with this patch, we can save about ~1K of xilpm runtime memory. With optimization: Total buffer size = 32768 bytes Used = 31200 bytes Free = 1568 bytes Without optimization: Total buffer size = 32768 bytes Used = 32256 bytes Free = 512 bytes On other devices, we'll likely save more memory. While at it, fix a bug in XPm_DumpMemUsage() which incorrectly casts pointers to (u32) before performing the arithmetic operation. This results in an incorrect result. Signed-off-by: Izhar Ameer Shaikh <izhar.ameer.shaikh@xilinx.com> Acked-by: Rajan Vaja <rajan.vaja@xilinx.com>
Move static functions into conditional section as they don't needs to be documented. Signed-off-by: Ronak Jain <ronak.jain@xilinx.com> Acked-for-series: Abhyuday Godhasara <abhyuday.godhasara@xilinx.com>
Add descriptions for enums to fix doxygen warnings. Signed-off-by: Ronak Jain <ronak.jain@xilinx.com> Acked-for-series: Abhyuday Godhasara <abhyuday.godhasara@xilinx.com>
This commit does the below --> Increments the driver version number. --> Updates addtogroup tags. --> Updates copyright year. Signed-off-by: Appana Durga Kedareswara rao <appana.durga.rao@xilinx.com> Acked-for-series: Siva Durga Prasad Paladugu <siva.durga.paladugu@xilinx.com>
While updating the address for Instruction Inject Register need to apply mask inorder to inject fault when instruction replacing the actual instruction at the IIR offset address. Signed-off-by: Appana Durga Kedareswara rao <appana.durga.rao@xilinx.com> Acked-for-series: Siva Durga Prasad Paladugu <siva.durga.paladugu@xilinx.com>
…Configure_BrkDelay() for configuring break delay This commits adds new API XTMR_Manager_Configure_BrkDelay() for configuring break delay. Signed-off-by: Appana Durga Kedareswara rao <appana.durga.rao@xilinx.com> Acked-for-series: Siva Durga Prasad Paladugu <siva.durga.paladugu@xilinx.com>
This commits adds an example for error injection and recovery using tmr inject and tmr manager IP's. Signed-off-by: Appana Durga Kedareswara rao <appana.durga.rao@xilinx.com> Acked-for-series: Siva Durga Prasad Paladugu <siva.durga.paladugu@xilinx.com>
Updated the define statement for TX_RX_RATE variable Signed-off-by: S Shreesh <s.shreesh@xilinx.com> Acked-for-series: Kapil Usgaonkar <kapil.usgaonkar@xilinx.com>
Updated the define statement for TX_RX_RATE variable Signed-off-by: S Shreesh <s.shreesh@xilinx.com> Acked-for-series: Kapil Usgaonkar <kapil.usgaonkar@xilinx.com>
Increment version. Update doxygen tags. Signed-off-by: Swati Agarwal <swati.agarwal@xilinx.com> Acked-for-series: Harini Katakam <harini.katakam@xilinx.com>
…unction Do not use global pointer to AxiDma structure. Use the instance pointer passed via function parameter instead. Signed-off-by: Swati Agarwal <swati.agarwal@xilinx.com> Acked-for-series: Harini Katakam <harini.katakam@xilinx.com>
Updated range details and notes for APIs for Doxygen Signed-off-by: Hariharan Baskaran <hariharan.baskaran@xilinx.com> Acked-by: Rama devi Veggalam <rama.devi.veggalam@xilinx.com>
Enhance feature check support for better execution. Remove bitmask function overhead and add MACRO to get IOCTL/QUERY ids version. Signed-off-by: Ronak Jain <ronak.jain@xilinx.com> Acked-by: Tanmay Shah <tanmay.shah@xilinx.com>
Updated the PLL configs to support audio for vck190 Signed-off-by: S Shreesh <s.shreesh@xilinx.com> Acked-for-series: Kapil Usgaonkar <kapil.usaonkar@xilinx.com>
Updated the PLL configs to support audio for vck190 Signed-off-by: S Shreesh <s.shreesh@xilinx.com> Acked-for-series: Kapil Usgaonkar <kapil.usaonkar@xilinx.com>
Updated the copyright license of the file Signed-off-by: S Shreesh <s.shreesh@xilinx.com> Acked-for-series: Kapil Usgaonkar <kapil.usgaonkar@xilinx.com>
Updated the copyright license of the file Signed-off-by: S Shreesh <s.shreesh@xilinx.com> Acked-for-series: Kapil Usgaonkar <kapil.usgaonkar@xilinx.com>
Updated the copyright license of the file Signed-off-by: S Shreesh <s.shreesh@xilinx.com> Acked-for-series: Kapil Usgaonkar <kapil.usgaonkar@xilinx.com>
Updated the copyright license of the file Signed-off-by: S Shreesh <s.shreesh@xilinx.com> Acked-for-series: Kapil Usgaonkar <kapil.usgaonkar@xilinx.com>
Uprevved the mdd for 2022.1 checkins Signed-off-by: S Shreesh <s.shreesh@xilinx.com> Acked-for-series: Kapil Usgaonkar <kapil.usgaonkar@xilinx.com>
Updated license for application files. Signed-off-by: nishantd <nishant.dhonde@xilinx.com> Acked-by: Kapil Usgaonkar <kapil.usgaonkar@xilinx.com>
… macro Moved the rx initialization outside of hdcp enabled macro Signed-off-by: nishantd <nishant.dhonde@xilinx.com> Acked-by: Kapil Usgaonkar <kapil.usgaonkar@xilinx.com>
Updated Print_DDRSize_Warning function to replace xil_printf with xdbg_printf. Signed-off-by: Mubin Usman Sayyed <mubin.usman.sayyed@xilinx.com> Acked-by: Siva Durga Prasad Paladugu <siva.durga.paladugu@xilinx.com>
…re set This patch updates the code such that unlimited number of attempts are allowed to enable JTAG when AUTH_JTAG_LOCK_DIS_1_0 is programmed. If the efuse bits are not set then only one failed attempt is allowed. It also adds temporal redundancy check for AuthFailCounter. It also changes local static variables in XLoader_CheckAuthJtagIntStatus() to file static variables. Signed-off-by: Harsha <harsha.harsha@xilinx.com> Acked-by: Mohan Marutirao Dhanawade <mohan.dhanawade@xilinx.com>
Currently after enabling ENABLE_DYNAMIC_MIO_CONFIG flag the ENABLE_IOCTL is not enabled. Similar issue is there for other flags as well like ENABLE_RUNTIME_OVERTEMP and ENABLE_RUNTIME_EXTWDT. Currently the ENABLE_DYNAMIC_MIO_CONFIG flag is enabled only when the ENABLE_DYNAMIC_MIO_CONFIG_VAL is set to 1. Fix the issue by adding separate check whether the ENABLE_DYNAMIC_MIO_CONFIG is defined or not. If defined then enable its dependent flags. Similar fix is added for ENABLE_RUNTIME_OVERTEMP and ENABLE_RUNTIME_EXTWDT flags as well. Signed-off-by: Ronak Jain <ronak.jain@xilinx.com> Acked-by: Abhyuday Godhasara <abhyuday.godhasara@xilinx.com>
AIE SMID range has been updated to 240 - 255 (0xF0 to 0xFF). As a result, update the ME_SMID_REG.ME_SMID[4:0] value with correct values. Signed-off-by: Izhar Ameer Shaikh <izhar.ameer.shaikh@xilinx.com> Acked-by: Rajan Vaja <rajan.vaja@xilinx.com>
Updated the checksum values for the latest edid Signed-off-by: S Shreesh <s.shreesh@xilinx.com> Acked-for-series: Kapil Usgaonkar <kapil.usgaonkar@xilinx.com>
Updated the checksum values for latest edid Signed-off-by: S Shreesh <s.shreesh@xilinx.com> Acked-for-series: Kapil Usgaonkar <kapil.usgaonkar@xilinx.com>
Update the change log for the versal PSMFW. Signed-off-by: Ronak Jain <ronak.jain@xilinx.com> Acked-by : Siva Addepalli<saddepal@xilinx.com>
This patch updates changelog for xilplmi component. Signed-off-by: Mounika Akula <mounika.akula@xilinx.com> Acked-by : Siva Addepalli<saddepal@xilinx.com>
Update change log for the XilPM for 2022.1 release. Signed-off-by: Ronak Jain <ronak.jain@xilinx.com> Acked-by : Siva Addepalli<saddepal@xilinx.com>
Revert name change of XSYSMONPSV_VAL_CURRENT back to XSYSMONPSV_VAL for better backwards compatibility Signed-off-by: Conall O'Griofa <conall.o'griofa@xilinx.com> Acked-by: Dragan Cvetic <draganc@xilinx.com>
…CES and XPAR_XDPTXSS_NUM_INSTANCES This patch moves RX specific code under XPAR_XDPRXSS_NUM_INSTANCES, and tx specific code under XPAR_XDPTXSS_NUM_INSTANCES with out this patch tx only system and rx only system gets failed to compile. Signed-off-by: Lakshmi Prasanna Eachuri <lakshmi.prasanna.eachuri@xilinx.com> Acked-for-series: Sandip Kothari <sandipk@xilinx.com>
This patch will enable hdp22_rng folder into bsp folder to avoid compilation issues when tx only system is enabled. Signed-off-by: Lakshmi Prasanna Eachuri <lakshmi.prasanna.eachuri@xilinx.com> Acked-for-series: Sandip Kothari <sandipk@xilinx.com>
This patch updates default data and data length in xilpuf_enc_dec_data_example and xilpuf_enc_dec_data_client_example. It also adds a check for zero data length. Signed-off-by: Harsha <harsha.harsha@xilinx.com> Acked-by: Mohan Marutirao Dhanawade <mohan.dhanawade@xilinx.com>
…r vcu118 rxo and txo in import application option. Modified the linker script bram memory size to 512k Signed-off-by: nishantd <nishant.dhonde@xilinx.com> Acked by: Kapil Usgaonkar <kapil.usgaonkar@xilinx.com>
Enhancing the change log for the XilPM component for 2022.1 release. The change log was added as part of below commit ID. Commit ID: Updated change log for XilPM (ff2cf4d) Signed-off-by: Ronak Jain <ronak.jain@xilinx.com> Acked-by: Izhar Ameer Shaikh <izhar.ameer.shaikh@xilinx.com>
Updated changelog for below components versal_plm trngpsv_v1_1 Signed-off-by: Meena Paleti <meena.paleti@xilinx.com> Acked-by : Siva Addepalli<saddepal@xilinx.com>
Updated Changelog for sysmonpsv_v3_0 Signed-off-by: Conall O'Griofa <conall.o'griofa@xilinx.com> Acked-by : Siva Addepalli<saddepal@xilinx.com>
Updated tcl to use C_S_AXI_BASEADDR and C_S_AXI_HIGHADDR instead of C_BASEADDR and C_HIGHADDR, in case of psv_pmc/psv_psm processors. This has been done to export correct base/high address values in case of SSIT devices. Also, in case of psv_pmc/psv_psm, base/high address is read through get_param_value proc instead of using get_property. Signed-off-by: Mubin Usman Sayyed <mubin.usman.sayyed@xilinx.com> Acked-by: Siva Durga Prasad Paladugu <siva.durga.paladugu@xilinx.com>
Update license file for EmbeddedSW 2022.1 release Signed-off-by: Manikanta Sreeram <msreeram@xilinx.com> Acked-by : Meena Paleti <meena.paleti@xilinx.com>
Updated standalone/src/changelog with recent modifications in standalone BSP. Signed-off-by: Mubin Usman Sayyed <mubin.usman.sayyed@xilinx.com>
A lot of people are trying to send pull requests via github but this is not the right channel to use. Linux project is doing review over emails that's why use git@xilinx.com if you want to contribute changes to this repository. Signed-off-by: Siva Addepalli <sivaprasad.addepalli@xilinx.com>
|
Hopefully you can get this one approved somehow. I reported this in 2019 with a proposed fix and it is still affecting customers. Supposedly it is going to be fixed in 2022.2: https://support.xilinx.com/s/question/0D52E00006hpmNcSAI/ip-rx-stack-crashes?language=en_US |
Contributor
|
We already have fixed this in 2022.2. |
Author
|
That's good to hear. I was working off of tag xilinx_v2022.1_update3 when looking for it, so I guess I must have been very close. Would have saved me half a week of work tracking this down if the fix had been in the repo already. Incidentally, could you maybe add a CONTRIBUTING file or similar at the root of the repo, so one doesn't have to go all the way to creating the actual pull request, before being asked not to? We don't use git-email in my organisation, so it was a bit of a bother trying to send you the patch by the proscribed route. |
saddepal
force-pushed
the
master
branch
2 times, most recently
from
e929ef8 to
51d9eed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please do not submit a Pull Request via github. Our project makes use of
mailing lists for patch submission and review. For more details please see
https://xilinx-wiki.atlassian.net/wiki/spaces/A/pages/18842172/Create+and+Submit+a+Patch