-
Notifications
You must be signed in to change notification settings - Fork 12
Update-source-download-snapshots #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughDocumentation URLs for Full Node and Archive Node snapshots are updated from Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/xdcchain/developers/node_operators/masternode.md(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
docs/xdcchain/developers/node_operators/masternode.md
522-522: Bare URL used
(MD034, no-bare-urls)
524-524: Bare URL used
(MD034, no-bare-urls)
526-526: Bare URL used
(MD034, no-bare-urls)
🔇 Additional comments (1)
docs/xdcchain/developers/node_operators/masternode.md (1)
564-604: Disregard this review comment — the analysis is reversed.The official mainnet snapshot URL is https://download.xinfin.network/xdcchain.tar, which is what line 576 correctly contains. https://rpc.xdc.network is an RPC endpoint for JSON-RPC queries, not a snapshot server, so updating line 576 to use
rpc.xdc.network/snapshots/mainnet/full/would break the documentation by replacing a valid endpoint with an invalid one.The actual inconsistency in the file is in the earlier "Setup XDC Masternode(Full Node)/Standby node using Snapshots" section, which incorrectly references
https://rpc.xdc.network/snapshots/mainnet/full/. However, that is not what this review identified.Likely an incorrect or invalid review comment.
Update link source download versions snapshots
Summary by CodeRabbit