Fix distributed deadlock when experiment log path exists#9
Open
prachitbhike wants to merge 1 commit intoYalaLab:mainfrom
Open
Fix distributed deadlock when experiment log path exists#9prachitbhike wants to merge 1 commit intoYalaLab:mainfrom
prachitbhike wants to merge 1 commit intoYalaLab:mainfrom
Conversation
When a log path already exists and --resume is not "latest", only rank 0 returned early while all other ranks hung at the next NCCL collective. Broadcast the exit decision to all ranks before returning so every process exits cleanly. Uses the existing broadcast_object utility, matching the pattern already used for resume_from at line ~687. Fixes YalaLab#4
f224242 to
f05e86f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--resume latest), leaving all other ranks hung at the next NCCL collectivebroadcast_objectutility before returning, so every process exits cleanlyDetails
In
src/trainer/main.py, whenargs.log_pathalready exists and--resumeis not"latest", the master rank (rank 0) calledreturn -1while all other ranks — already in the NCCL process group viainit_distributed_device()— hung forever at the next collective operation.The fix introduces a
should_exitflag that is broadcast from rank 0 to all ranks before any early return. This matches the existing pattern used forresume_fromat line ~687.Non-distributed case: The
if args.distributedguard skips the broadcast; single-process training returns-1exactly as before.Fixes #4
Test plan
torchrun --nproc_per_node=2) exits cleanly on all ranks when experiment exists🤖 Generated with Claude Code