Skip to content

Conversation

@mlovci
Copy link

@mlovci mlovci commented Jun 16, 2017

Automates local conda build before installation.

Solves this problem:

$ conda create --name outrigger-env_ outrigger
Fetching package metadata .............

PackageNotFoundError: Package missing in current osx-64 channels:
  - outrigger

Michael Lovci added 2 commits June 16, 2017 16:13
Add make directive to build conda environment locally.
Make directive to build conda env locally

install: clean
environment:
-conda env create -f environment.yml
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove dash at beginning of line (probably a holdover from the yaml file)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(it's intentional, see PR comments)

@olgabot
Copy link
Collaborator

olgabot commented Jun 17, 2017

Thank you! Makefiles use exactly tabs and no spaces for the directions, so double-check that the makefile is valid

@olgabot
Copy link
Collaborator

olgabot commented Jun 17, 2017

Is this something you wanted to add to the .travis.yml file as well? Or for installation? I ask because if it's for installation, it should also be documented in the README.rst

@mlovci
Copy link
Author

mlovci commented Jun 20, 2017

Thanks for the tabs reminder. The dash is intentional before the environment directive, it will allow steps that require it to pass if that fails (for example, if the environment exists). I'm submitting another PR with code to do the conda env activation before install. Re-submitting with more changes to instructions and .travis.yml

@mlovci mlovci closed this Jun 20, 2017
@mlovci mlovci reopened this Jun 20, 2017
@mlovci
Copy link
Author

mlovci commented Jun 20, 2017

Nevermind about re-submitting, the new commits are already here.

@olgabot
Copy link
Collaborator

olgabot commented Jun 28, 2017

Can you check on the failing builds? Here's an excerpt:

source activate `cat environment.yml |grep name | cut -f2 -d " "` && python setup.py install
/bin/sh: 1: source: not found
make: *** [install] Error 127
The command "make install" failed and exited with 2 during .
Your build has been stopped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants