-
Notifications
You must be signed in to change notification settings - Fork 32
macOS port #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
macOS port #37
Conversation
README.md
Outdated
| The implementation makes use of libusb for Linux builds and hidapi for Windows. | ||
| For Linux we include a build and installation script, `build.sh` and `install.sh` respectively, for building and installing the application. | ||
| The implementation makes use of libusb for Linux builds and hidapi for macOS and Windows. | ||
| For Linux nad macOS we include a build and installation script, `build.sh` and `install.sh` respectively, for building and installing the application. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small typo here, "nad" instead of "and".
Thanks for cleaning up my proof of concept mess! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem - thanks for the proof of concept to get started.
|
Hey, firstly thanks for implementing this. I had a few issues getting this to work on an M1 Mac (Apple Silicon): Missing pkg-configFirstly I hadn't got pkg-config installed, I fixed this with
I'd suggest adding this to install instructions as you've done with hidapi Linker ErrorI then had a linker error
This took me a while to figure out a workaround for, I'm not sure it's the best way of handling it however with
I'm guessing this is more of a Silicon specific issue with the move of homebrew to /opt I wonder if there's a better way of handling this Install ErrorThis then successfully compiled and linked producing an executable. However running I manually copied it to another folder in PATH and it now seems happy. |
This PR is based on mikaeleiman's #36
It first detects the OS type in the Makefile using uname and picks hidapi for macOS and libusb for linux as before.